From 6924416de82d67f0e7d4674501f863ef24dd1a91 Mon Sep 17 00:00:00 2001 From: Oleksiy Ivanov Date: Thu, 16 Aug 2018 08:41:49 -0700 Subject: [PATCH] Fix for compilation error about missing virtual destructor in GCDQueue (#236) Summary: error: destructor called on non-final 'facebook::sonar::GCDQueue' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] __data_.second().~_Tp(); Pull Request resolved: https://github.com/facebook/flipper/pull/236 Reviewed By: passy Differential Revision: D9351946 Pulled By: priteshrnandgaonkar fbshipit-source-id: 4718460ff587e1d5fa475a5f3bf115b1e2b5305f --- .../SonarKitNetworkPlugin/SKDispatchQueue.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/iOS/Plugins/SonarKitNetworkPlugin/SonarKitNetworkPlugin/SKDispatchQueue.h b/iOS/Plugins/SonarKitNetworkPlugin/SonarKitNetworkPlugin/SKDispatchQueue.h index bce514719..b0ef80561 100644 --- a/iOS/Plugins/SonarKitNetworkPlugin/SonarKitNetworkPlugin/SKDispatchQueue.h +++ b/iOS/Plugins/SonarKitNetworkPlugin/SonarKitNetworkPlugin/SKDispatchQueue.h @@ -30,6 +30,8 @@ namespace facebook { dispatch_async(_underlyingQueue, block); } + virtual ~GCDQueue() { } + private: dispatch_queue_t _underlyingQueue; };