Bump prettier from 2.2.1 to 2.3.0 in /desktop (#2300)

Summary:
Bumps [prettier](https://github.com/prettier/prettier) from 2.2.1 to 2.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/prettier/prettier/releases">prettier's releases</a>.</em></p>
<blockquote>
<h2>2.3.0</h2>
<p><a href="https://github.com/prettier/prettier/compare/2.2.1...2.3.0">diff</a></p>
<p>{emoji:1f517} <a href="https://prettier.io/blog/2021/05/09/2.3.0.html">Release Notes</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prettier/prettier/blob/main/CHANGELOG.md">prettier's changelog</a>.</em></p>
<blockquote>
<h1>2.3.0</h1>
<p><a href="https://github.com/prettier/prettier/compare/2.2.1...2.3.0">diff</a></p>
<p>{emoji:1f517} <a href="https://prettier.io/blog/2021/05/09/2.3.0.html">Release Notes</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="2afc3b9ae6"><code>2afc3b9</code></a> Release 2.3.0</li>
<li><a href="7cfa9aa89b"><code>7cfa9aa</code></a> Fix pre-commit hook setup command (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10710">#10710</a>)</li>
<li><a href="c8c02b4753"><code>c8c02b4</code></a> Build(deps-dev): Bump concurrently from 6.0.2 to 6.1.0 in /website (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10834">#10834</a>)</li>
<li><a href="6506e0f50e"><code>6506e0f</code></a> Build(deps-dev): Bump webpack-cli from 4.6.0 to 4.7.0 in /website (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10836">#10836</a>)</li>
<li><a href="69fae9c291"><code>69fae9c</code></a> Build(deps): Bump flow-parser from 0.150.0 to 0.150.1 (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10839">#10839</a>)</li>
<li><a href="164a6e2351"><code>164a6e2</code></a> Switch CLI to async (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10804">#10804</a>)</li>
<li><a href="d3e7e2f634"><code>d3e7e2f</code></a> Build(deps): Bump codecov/codecov-action from v1.4.1 to v1.5.0 (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10833">#10833</a>)</li>
<li><a href="9e09845da0"><code>9e09845</code></a> Build(deps): Bump <code>@​angular/compiler</code> from 11.2.12 to 11.2.13 (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10838">#10838</a>)</li>
<li><a href="1bfab3d045"><code>1bfab3d</code></a> Build(deps-dev): Bump eslint from 7.25.0 to 7.26.0 (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10840">#10840</a>)</li>
<li><a href="387fce4ed8"><code>387fce4</code></a> Minor formatting tweaks (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/10807">#10807</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/prettier/prettier/compare/2.2.1...2.3.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=prettier&package-manager=npm_and_yarn&previous-version=2.2.1&new-version=2.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2300

Reviewed By: passy

Differential Revision: D28323849

Pulled By: cekkaewnumchai

fbshipit-source-id: 1842877ccc9a9587af7f0d9ff9432c2075c8ee22

desktop/app/src/NotificationsHub.tsx

@@ -157,9 +157,8 @@ class NotificationsTable extends Component<Props & SearchableProps, State> {
     );
   };
 
-  getFilter = (): ((n: PluginNotification) => boolean) => (
+  getFilter =
-    n: PluginNotification,
+    (): ((n: PluginNotification) => boolean) => (n: PluginNotification) => {
-  ) => {
       const searchTerm = this.props.searchTerm.toLowerCase();
 
       // filter plugins

desktop/app/src/PluginContainer.tsx

@@ -207,13 +207,8 @@ class PluginContainer extends PureComponent<Props, State> {
   }
 
   processMessageQueue() {
-    const {
+    const {pluginKey, pendingMessages, activePlugin, pluginIsEnabled, target} =
-      pluginKey,
+      this.props;
-      pendingMessages,
-      activePlugin,
-      pluginIsEnabled,
-      target,
-    } = this.props;
     if (pluginKey !== this.pluginBeingProcessed) {
       this.pluginBeingProcessed = pluginKey;
       this.cancelCurrentQueue();
@@ -273,13 +268,8 @@ class PluginContainer extends PureComponent<Props, State> {
   }
 
   render() {
-    const {
+    const {activePlugin, pluginKey, target, pendingMessages, pluginIsEnabled} =
-      activePlugin,
+      this.props;
-      pluginKey,
-      target,
-      pendingMessages,
-      pluginIsEnabled,
-    } = this.props;
     if (!activePlugin || !target || !pluginKey) {
       return null;
     }

desktop/app/src/__tests__/PluginContainer.node.tsx

@@ -150,13 +150,8 @@ test('PluginContainer can render Sandy plugins', async () => {
       Component: MySandyPlugin,
     },
   );
-  const {
+  const {renderer, act, sendMessage, client, store} =
-    renderer,
+    await renderMockFlipperWithPlugin(definition);
-    act,
-    sendMessage,
-    client,
-    store,
-  } = await renderMockFlipperWithPlugin(definition);
 
   expect(client.rawSend).toBeCalledWith('init', {plugin: 'TestPlugin'});
 
@@ -211,9 +206,8 @@ test('PluginContainer can render Sandy plugins', async () => {
   `);
 
   // make sure the plugin gets connected
-  const pluginInstance: ReturnType<
+  const pluginInstance: ReturnType<typeof plugin> =
-    typeof plugin
+    client.sandyPluginStates.get(definition.id)!.instanceApi;
-  > = client.sandyPluginStates.get(definition.id)!.instanceApi;
   expect(pluginInstance.connectedStub).toBeCalledTimes(1);
   expect(pluginInstance.disconnectedStub).toBeCalledTimes(0);
   expect(pluginInstance.activatedStub).toBeCalledTimes(1);
@@ -359,9 +353,8 @@ test('PluginContainer triggers correct lifecycles for background plugin', async
   expect(client.rawSend).toBeCalledWith('init', {plugin: 'TestPlugin'});
   (client.rawSend as jest.Mock).mockClear();
   // make sure the plugin gets connected
-  const pluginInstance: ReturnType<
+  const pluginInstance: ReturnType<typeof plugin> =
-    typeof plugin
+    client.sandyPluginStates.get(definition.id)!.instanceApi;
-  > = client.sandyPluginStates.get(definition.id)!.instanceApi;
   expect(pluginInstance.connectedStub).toBeCalledTimes(1);
   expect(pluginInstance.disconnectedStub).toBeCalledTimes(0);
   expect(pluginInstance.activatedStub).toBeCalledTimes(1);
@@ -440,9 +433,8 @@ test('PluginContainer triggers correct lifecycles for background plugin', async
   expect(pluginInstance.activatedStub).toBeCalledTimes(2);
   expect(pluginInstance.deactivatedStub).toBeCalledTimes(2);
 
-  const newPluginInstance: ReturnType<
+  const newPluginInstance: ReturnType<typeof plugin> =
-    typeof plugin
+    client.sandyPluginStates.get('TestPlugin')!.instanceApi;
-  > = client.sandyPluginStates.get('TestPlugin')!.instanceApi;
   expect(newPluginInstance.connectedStub).toBeCalledTimes(1);
   expect(newPluginInstance.disconnectedStub).toBeCalledTimes(0);
   expect(newPluginInstance.activatedStub).toBeCalledTimes(0);
@@ -705,9 +697,8 @@ test('PluginContainer can render Sandy device plugins', async () => {
   `);
 
   // make sure the plugin gets connected
-  const pluginInstance: ReturnType<
+  const pluginInstance: ReturnType<typeof devicePlugin> =
-    typeof devicePlugin
+    device.sandyPluginStates.get(definition.id)!.instanceApi;
-  > = device.sandyPluginStates.get(definition.id)!.instanceApi;
   expect(pluginInstance.activatedStub).toBeCalledTimes(1);
   expect(pluginInstance.deactivatedStub).toBeCalledTimes(0);
 
@@ -959,9 +950,8 @@ test('Sandy plugins support isPluginSupported + selectPlugin', async () => {
   `);
   expect(renders).toBe(1);
 
-  const pluginInstance: ReturnType<
+  const pluginInstance: ReturnType<typeof plugin> =
-    typeof plugin
+    client.sandyPluginStates.get(definition.id)!.instanceApi;
-  > = client.sandyPluginStates.get(definition.id)!.instanceApi;
   expect(pluginInstance.isPluginAvailable(definition.id)).toBeTruthy();
   expect(pluginInstance.isPluginAvailable('nonsense')).toBeFalsy();
   expect(pluginInstance.isPluginAvailable(definition2.id)).toBeFalsy(); // not enabled yet
@@ -1076,12 +1066,10 @@ test('PluginContainer can render Sandy plugins for archived devices', async () =
       Component: MySandyPlugin,
     },
   );
-  const {
+  const {renderer, act, client, store} = await renderMockFlipperWithPlugin(
-    renderer,
+    definition,
-    act,
+    {archivedDevice: true},
-    client,
+  );
-    store,
-  } = await renderMockFlipperWithPlugin(definition, {archivedDevice: true});
 
   expect(client.rawSend).not.toBeCalled();
 
@@ -1106,9 +1094,8 @@ test('PluginContainer can render Sandy plugins for archived devices', async () =
   expect(renders).toBe(1);
 
   // make sure the plugin gets activated, but not connected!
-  const pluginInstance: ReturnType<
+  const pluginInstance: ReturnType<typeof plugin> =
-    typeof plugin
+    client.sandyPluginStates.get(definition.id)!.instanceApi;
-  > = client.sandyPluginStates.get(definition.id)!.instanceApi;
   expect(pluginInstance.connectedStub).toBeCalledTimes(0);
   expect(pluginInstance.disconnectedStub).toBeCalledTimes(0);
   expect(pluginInstance.activatedStub).toBeCalledTimes(1);
@@ -1210,9 +1197,8 @@ test('PluginContainer triggers correct lifecycles for background plugin', async
 
   expect(client.rawSend).not.toBeCalled();
   // make sure the plugin gets connected
-  const pluginInstance: ReturnType<
+  const pluginInstance: ReturnType<typeof plugin> =
-    typeof plugin
+    client.sandyPluginStates.get(definition.id)!.instanceApi;
-  > = client.sandyPluginStates.get(definition.id)!.instanceApi;
   expect(pluginInstance.connectedStub).toBeCalledTimes(0);
   expect(pluginInstance.disconnectedStub).toBeCalledTimes(0);
   expect(pluginInstance.activatedStub).toBeCalledTimes(1);

desktop/app/src/__tests__/createMockFlipperWithPlugin.node.tsx

@@ -40,12 +40,8 @@ class TestPlugin extends FlipperPlugin<any, any, any> {
 }
 
 test('can create a Fake flipper', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   expect(client).toBeTruthy();
   expect(device).toBeTruthy();
   expect(store).toBeTruthy();

desktop/app/src/__tests__/createTablePlugin.node.tsx

@@ -66,10 +66,7 @@ test('persistedStateReducer is adding data', () => {
   const tablePlugin = createTablePlugin({...PROPS, method});
   const id = '1';
 
-  const {
+  const {rows, datas} = tablePlugin.persistedStateReducer(
-    rows,
-    datas,
-  } = tablePlugin.persistedStateReducer(
     tablePlugin.defaultPersistedState,
     method,
     {id},

desktop/app/src/__tests__/disconnect.node.tsx

@@ -213,12 +213,8 @@ test('new clients replace old ones', async () => {
       },
     },
   );
-  const {
+  const {client, store, device, createClient} =
-    client,
+    await createMockFlipperWithPlugin(plugin, {
-    store,
-    device,
-    createClient,
-  } = await createMockFlipperWithPlugin(plugin, {
       asBackgroundPlugin: true,
     });
 

desktop/app/src/chrome/RatingButton.tsx

@@ -372,10 +372,8 @@ class RatingButton extends Component<PropsFromState, State> {
 }
 
 export function SandyRatingButton() {
-  const [
+  const [promptData, setPromptData] =
-    promptData,
+    useState<UserFeedback.FeedbackPrompt | null>(null);
-    setPromptData,
-  ] = useState<UserFeedback.FeedbackPrompt | null>(null);
   const [isShown, setIsShown] = useState(false);
   const [hasTriggered, setHasTriggered] = useState(false);
   const sessionId = useStore((store) => store.application.sessionId);

desktop/app/src/chrome/ShareSheetExportUrl.tsx

@@ -122,10 +122,8 @@ export default class ShareSheetExportUrl extends Component<Props, State> {
           this.setState({statusUpdate: msg});
         }
       };
-      const {
+      const {serializedString, fetchMetaDataErrors} =
-        serializedString,
+        await reportPlatformFailures(
-        fetchMetaDataErrors,
-      } = await reportPlatformFailures(
           exportStore(this.store, false, this.idler, statusUpdate),
           `${EXPORT_FLIPPER_TRACE_EVENT}:UI_LINK`,
         );

desktop/app/src/chrome/UpdateIndicator.tsx

@@ -32,10 +32,8 @@ export type VersionCheckResult =
     };
 
 export default function UpdateIndicator() {
-  const [
+  const [versionCheckResult, setVersionCheckResult] =
-    versionCheckResult,
+    useState<VersionCheckResult>({kind: 'up-to-date'});
-    setVersionCheckResult,
-  ] = useState<VersionCheckResult>({kind: 'up-to-date'});
   const launcherMsg = useStore((state) => state.application.launcherMsg);
 
   // Effect to show notification if details change

desktop/app/src/chrome/__tests__/ExportDataPluginSheet.node.tsx

@@ -42,13 +42,8 @@ TestDevicePlugin.defaultPersistedState = {msg: 'TestDevicePlugin'};
 
 test('SettingsSheet snapshot with nothing enabled', async () => {
   let root: ReactTestRenderer;
-  const {
+  const {store, togglePlugin, client, device, pluginKey} =
-    store,
+    await createMockFlipperWithPlugin(TestPlugin, {
-    togglePlugin,
-    client,
-    device,
-    pluginKey,
-  } = await createMockFlipperWithPlugin(TestPlugin, {
       additionalPlugins: [TestDevicePlugin],
     });
 

desktop/app/src/chrome/plugin-manager/PluginInstaller.tsx

@@ -185,10 +185,9 @@ function InstallButton(props: {
     | {kind: 'Remove'; error?: string}
     | {kind: 'Update'; error?: string};
 
-  const catchError = (
+  const catchError =
-    actionKind: 'Install' | 'Remove' | 'Update',
+    (actionKind: 'Install' | 'Remove' | 'Update', fn: () => Promise<void>) =>
-    fn: () => Promise<void>,
+    async () => {
-  ) => async () => {
       try {
         await fn();
       } catch (err) {

desktop/app/src/chrome/settings/KeyboardShortcutInput.tsx

@@ -112,12 +112,10 @@ const KeyboardShortcutInput = (props: {
   const [initialPressedKeys] = useState<PressedKeys>(
     getInitialStateFromProps(),
   );
-  const [pressedKeys, setPressedKeys] = useState<PressedKeys>(
+  const [pressedKeys, setPressedKeys] =
-    initialPressedKeys,
+    useState<PressedKeys>(initialPressedKeys);
-  );
+  const [isShortcutValid, setIsShortcutValid] =
-  const [isShortcutValid, setIsShortcutValid] = useState<boolean | undefined>(
+    useState<boolean | undefined>(undefined);
-    undefined,
-  );
 
   useEffect(() => {
     if (!isShortcutValid) {

desktop/app/src/devices/__tests__/BaseDevice.node.tsx

@@ -69,8 +69,8 @@ const iosEmulatorDevicePlugin = new _SandyPluginDefinition(
   iosEmulatorlDevicePluginDetails,
   DeviceTestPluginModule,
 );
-const androiKaiosPhysicalDevicePluginDetails = TestUtils.createMockPluginDetails(
+const androiKaiosPhysicalDevicePluginDetails =
-  {
+  TestUtils.createMockPluginDetails({
     id: 'androidPhysicalDevicePlugin',
     name: 'flipper-plugin-android-physical-device',
     version: '0.0.1',
@@ -82,8 +82,7 @@ const androiKaiosPhysicalDevicePluginDetails = TestUtils.createMockPluginDetails
         specs: ['KaiOS'],
       },
     ],
-  },
+  });
-);
 const androidKaiosPhysicalDevicePlugin = new _SandyPluginDefinition(
   androiKaiosPhysicalDevicePluginDetails,
   DeviceTestPluginModule,

desktop/app/src/dispatcher/androidDevice.tsx

@@ -47,16 +47,9 @@ function createDevice(
           const isKaiOSDevice = Object.keys(props).some(
             (name) => name.startsWith('kaios') || name.startsWith('ro.kaios'),
           );
-          const androidLikeDevice = new (isKaiOSDevice
+          const androidLikeDevice = new (
-            ? KaiOSDevice
+            isKaiOSDevice ? KaiOSDevice : AndroidDevice
-            : AndroidDevice)(
+          )(device.id, type, name, adbClient, abiList, sdkVersion);
-            device.id,
-            type,
-            name,
-            adbClient,
-            abiList,
-            sdkVersion,
-          );
           if (ports) {
             await androidLikeDevice
               .reverse([ports.secure, ports.insecure])

desktop/app/src/dispatcher/notifications.tsx

@@ -100,9 +100,8 @@ export default (store: Store, logger: Logger) => {
             return;
           }
 
-          const persistingPlugin: undefined | PluginDefinition = getPlugin(
+          const persistingPlugin: undefined | PluginDefinition =
-            pluginName,
+            getPlugin(pluginName);
-          );
           if (
             persistingPlugin &&
             !isSandyPlugin(persistingPlugin) &&
@@ -129,11 +128,8 @@ export default (store: Store, logger: Logger) => {
         }
       });
 
-      const {
+      const {activeNotifications, blocklistedPlugins, blocklistedCategories} =
-        activeNotifications,
+        notifications;
-        blocklistedPlugins,
-        blocklistedCategories,
-      } = notifications;
 
       activeNotifications
         .map((n) => ({

desktop/app/src/dispatcher/plugins.tsx

@@ -124,7 +124,7 @@ function reportVersion(pluginDetails: ActivatablePluginDetails) {
 
 export function filterNewestVersionOfEachPlugin<
   T1 extends PluginDetails,
-  T2 extends PluginDetails
+  T2 extends PluginDetails,
 >(bundledPlugins: T1[], dynamicPlugins: T2[]): (T1 | T2)[] {
   const pluginByName: {[key: string]: T1 | T2} = {};
   for (const plugin of bundledPlugins) {
@@ -170,9 +170,9 @@ export async function getDynamicPlugins() {
   }
 }
 
-export const checkGK = (gatekeepedPlugins: Array<ActivatablePluginDetails>) => (
+export const checkGK =
-  plugin: ActivatablePluginDetails,
+  (gatekeepedPlugins: Array<ActivatablePluginDetails>) =>
-): boolean => {
+  (plugin: ActivatablePluginDetails): boolean => {
     try {
       if (!plugin.gatekeeper) {
         return true;
@@ -186,7 +186,7 @@ export const checkGK = (gatekeepedPlugins: Array<ActivatablePluginDetails>) => (
       console.error(`Failed to check GK for plugin ${plugin.id}`, err);
       return false;
     }
-};
+  };
 
 export const checkDisabled = (
   disabledPlugins: Array<ActivatablePluginDetails>,

desktop/app/src/dispatcher/tracking.tsx

@@ -89,11 +89,8 @@ export default (store: Store, logger: Logger) => {
       timeSinceLastStartup,
     });
     // create fresh exit data
-    const {
+    const {selectedDevice, selectedApp, selectedPlugin} =
-      selectedDevice,
+      store.getState().connections;
-      selectedApp,
-      selectedPlugin,
-    } = store.getState().connections;
     persistExitData(
       {
         selectedDevice,
@@ -142,12 +139,8 @@ export default (store: Store, logger: Logger) => {
       );
       return;
     }
-    const {
+    const {selectedDevice, selectedPlugin, selectedApp, clients} =
-      selectedDevice,
+      state.connections;
-      selectedPlugin,
-      selectedApp,
-      clients,
-    } = state.connections;
 
     persistExitData(
       {selectedDevice, selectedPlugin, selectedApp},

desktop/app/src/fb-stubs/__mocks__/Logger.tsx

@@ -20,9 +20,10 @@ const instance = {
   debug: jest.fn(),
 };
 
-export function extractError(
+export function extractError(...data: Array<any>): {
-  ...data: Array<any>
+  message: string;
-): {message: string; error: Error} {
+  error: Error;
+} {
   const message = data.map(getStringFromErrorLike).join(' ');
   const error = data.find((e) => e instanceof Error) || new Error(message);
   return {

desktop/app/src/init.tsx

@@ -206,11 +206,9 @@ function init() {
       dark: state.settingsState.darkMode,
     }),
     (theme) => {
-      (document.getElementById(
+      (
-        'flipper-theme-import',
+        document.getElementById('flipper-theme-import') as HTMLLinkElement
-      ) as HTMLLinkElement).href = `themes/${
+      ).href = `themes/${theme.dark ? 'dark' : 'light'}.css`;
-        theme.dark ? 'dark' : 'light'
-      }.css`;
     },
   );
 }

desktop/app/src/plugin.tsx

@@ -96,7 +96,7 @@ type StaticPersistedState = any;
 export abstract class FlipperBasePlugin<
   State,
   Actions extends BaseAction,
-  PersistedState
+  PersistedState,
 > extends Component<Props<PersistedState>, State> {
   abstract ['constructor']: any;
   static title: string | null = null;
@@ -197,7 +197,7 @@ export abstract class FlipperBasePlugin<
 export class FlipperDevicePlugin<
   S,
   A extends BaseAction,
-  P
+  P,
 > extends FlipperBasePlugin<S, A, P> {
   ['constructor']: typeof FlipperPlugin;
   device: BaseDevice;
@@ -226,7 +226,7 @@ export class FlipperDevicePlugin<
 export class FlipperPlugin<
   S,
   A extends BaseAction,
-  P
+  P,
 > extends FlipperBasePlugin<S, A, P> {
   ['constructor']: typeof FlipperPlugin;
   constructor(props: Props<P>) {

desktop/app/src/plugins/TableNativePlugin.tsx

@@ -470,13 +470,8 @@ export default function createTableNativePlugin(id: string, title: string) {
       if (!this.props.persistedState.tableMetadata) {
         return 'Loading...';
       }
-      const {
+      const {topToolbar, bottomToolbar, columns, columnSizes, columnOrder} =
-        topToolbar,
+        this.props.persistedState.tableMetadata;
-        bottomToolbar,
-        columns,
-        columnSizes,
-        columnOrder,
-      } = this.props.persistedState.tableMetadata;
       const {rows} = this.props.persistedState;
 
       const topToolbarComponent = topToolbar ? renderToolbar(topToolbar) : null;

desktop/app/src/reducers/__tests__/sandydeviceplugins.node.tsx

@@ -71,8 +71,9 @@ test('it should initialize device sandy plugins', async () => {
   expect(device.sandyPluginStates.get(TestPlugin.id)).toBeInstanceOf(
     _SandyDevicePluginInstance,
   );
-  const instanceApi: PluginApi = device.sandyPluginStates.get(TestPlugin.id)!
+  const instanceApi: PluginApi = device.sandyPluginStates.get(
-    .instanceApi;
+    TestPlugin.id,
+  )!.instanceApi;
 
   expect(instanceApi.activateStub).toBeCalledTimes(0);
   selectTestPlugin(store);

desktop/app/src/reducers/__tests__/sandyplugins.node.tsx

@@ -85,8 +85,9 @@ test('it should initialize starred sandy plugins', async () => {
   expect(client.sandyPluginStates.get(TestPlugin.id)).toBeInstanceOf(
     _SandyPluginInstance,
   );
-  const instanceApi: PluginApi = client.sandyPluginStates.get(TestPlugin.id)!
+  const instanceApi: PluginApi = client.sandyPluginStates.get(
-    .instanceApi;
+    TestPlugin.id,
+  )!.instanceApi;
 
   expect(instanceApi.connectStub).toBeCalledTimes(0);
   selectTestPlugin(store, client);
@@ -104,8 +105,9 @@ test('it should cleanup a plugin if disabled', async () => {
   const {client, store} = await createMockFlipperWithPlugin(TestPlugin);
 
   expect(TestPlugin.asPluginModule().plugin).toBeCalledTimes(1);
-  const pluginInstance: PluginApi = client.sandyPluginStates.get(TestPlugin.id)!
+  const pluginInstance: PluginApi = client.sandyPluginStates.get(
-    .instanceApi;
+    TestPlugin.id,
+  )!.instanceApi;
   expect(pluginInstance.destroyStub).toHaveBeenCalledTimes(0);
   client.initPlugin(TestPlugin.id);
   expect(pluginInstance.connectStub).toHaveBeenCalledTimes(1);
@@ -210,8 +212,9 @@ test('it trigger hooks for background plugins', async () => {
   const {client} = await createMockFlipperWithPlugin(TestPlugin, {
     asBackgroundPlugin: true,
   });
-  const pluginInstance: PluginApi = client.sandyPluginStates.get(TestPlugin.id)!
+  const pluginInstance: PluginApi = client.sandyPluginStates.get(
-    .instanceApi;
+    TestPlugin.id,
+  )!.instanceApi;
   expect(client.isBackgroundPlugin(TestPlugin.id)).toBeTruthy();
   expect(pluginInstance.destroyStub).toHaveBeenCalledTimes(0);
   expect(pluginInstance.connectStub).toHaveBeenCalledTimes(1);
@@ -234,8 +237,9 @@ test('it can send messages from sandy clients', async () => {
       }
     },
   });
-  const pluginInstance: PluginApi = client.sandyPluginStates.get(TestPlugin.id)!
+  const pluginInstance: PluginApi = client.sandyPluginStates.get(
-    .instanceApi;
+    TestPlugin.id,
+  )!.instanceApi;
   // without rendering, non-bg plugins won't connect automatically,
   client.initPlugin(TestPlugin.id);
   await pluginInstance.send('test', {test: 3});

desktop/app/src/reducers/supportForm.tsx

@@ -124,8 +124,8 @@ export class Group {
     let errorMessage: string | undefined = undefined;
     if (selectedApp) {
       const {app} = deconstructClientId(selectedApp);
-      const enabledPlugins: Array<string> | null = store.getState().connections
+      const enabledPlugins: Array<string> | null =
-        .enabledPlugins[app];
+        store.getState().connections.enabledPlugins[app];
       const unsupportedPlugins = [];
       for (const requiredPlugin of this.requiredPlugins) {
         const requiredPluginEnabled =

desktop/app/src/sandy-chrome/SandyApp.tsx

@@ -61,10 +61,8 @@ export function SandyApp() {
    * The logic here is to sync both, but without modifying the navigation related reducers to not break classic Flipper.
    * It is possible to simplify this in the future.
    */
-  const [
+  const [toplevelSelection, setStoredToplevelSelection] =
-    toplevelSelection,
+    useState<ToplevelNavItem>('appinspect');
-    setStoredToplevelSelection,
-  ] = useState<ToplevelNavItem>('appinspect');
 
   // Handle toplevel nav clicks from LeftRail
   const setToplevelSelection = useCallback(

desktop/app/src/sandy-chrome/SetupDoctorScreen.tsx

@@ -212,9 +212,10 @@ export default function SetupDoctorScreen(props: {
   const [acknowlodgeProblem, setAcknowlodgeProblem] = useState(
     checkHasNewProblem(healthcheckReport.result),
   );
-  const hasProblem = useMemo(() => checkHasProblem(healthcheckReport.result), [
+  const hasProblem = useMemo(
-    healthcheckReport,
+    () => checkHasProblem(healthcheckReport.result),
-  ]);
+    [healthcheckReport],
+  );
   const onCloseModal = useCallback(() => {
     const hasNewProblem = checkHasNewProblem(healthcheckReport.result);
     if (acknowlodgeProblem) {

desktop/app/src/sandy-chrome/appinspect/AppSelector.tsx

@@ -49,13 +49,8 @@ function getOsIcon(os?: OS) {
 
 export function AppSelector() {
   const dispatch = useDispatch();
-  const {
+  const {devices, selectedDevice, clients, uninitializedClients, selectedApp} =
-    devices,
+    useStore((state) => state.connections);
-    selectedDevice,
-    clients,
-    uninitializedClients,
-    selectedApp,
-  } = useStore((state) => state.connections);
   useValue(selectedDevice?.connected, false); // subscribe to future archived state changes
 
   const onSelectDevice = useTrackedCallback(

desktop/app/src/sandy-chrome/appinspect/BookmarkSection.tsx

@@ -46,10 +46,10 @@ function BookmarkSectionInput({navPlugin}: {navPlugin: NavigationPlugin}) {
   const bookmarks = useValue(navPlugin.bookmarks);
   const patterns = useValue(navPlugin.appMatchPatterns);
 
-  const isBookmarked = useMemo(() => bookmarks.has(currentURI), [
+  const isBookmarked = useMemo(
-    bookmarks,
+    () => bookmarks.has(currentURI),
-    currentURI,
+    [bookmarks, currentURI],
-  ]);
+  );
 
   const autoCompleteItems = useMemoize(
     navPlugin.getAutoCompleteAppMatchPatterns,

desktop/app/src/sandy-chrome/appinspect/PluginList.tsx

@@ -493,10 +493,12 @@ const PluginMenu = styled(Menu)({
   '.ant-menu-sub.ant-menu-inline': {
     background: theme.backgroundDefault,
   },
-  '.ant-menu-inline .ant-menu-item, .ant-menu-inline .ant-menu-submenu-title ': {
+  '.ant-menu-inline .ant-menu-item, .ant-menu-inline .ant-menu-submenu-title ':
+    {
       width: '100%', // reset to remove weird bonus pixel from ANT
     },
-  '.ant-menu-submenu > .ant-menu-submenu-title, .ant-menu-sub.ant-menu-inline > .ant-menu-item': {
+  '.ant-menu-submenu > .ant-menu-submenu-title, .ant-menu-sub.ant-menu-inline > .ant-menu-item':
+    {
       borderRadius: theme.borderRadius,
       height: '32px',
       lineHeight: '24px',
@@ -517,7 +519,8 @@ const PluginMenu = styled(Menu)({
         color: theme.white,
       },
     },
-  '.ant-menu-submenu-inline > .ant-menu-submenu-title .ant-menu-submenu-arrow': {
+  '.ant-menu-submenu-inline > .ant-menu-submenu-title .ant-menu-submenu-arrow':
+    {
       right: 8,
     },
   '.ant-badge-count': {

desktop/app/src/server.tsx

@@ -292,16 +292,8 @@ class Server extends EventEmitter {
     });
     this.connectionTracker.logConnectionAttempt(clientData);
 
-    const {
+    const {app, os, device, device_id, sdk_version, csr, csr_path, medium} =
-      app,
+      clientData;
-      os,
-      device,
-      device_id,
-      sdk_version,
-      csr,
-      csr_path,
-      medium,
-    } = clientData;
     const transformedMedium = transformCertificateExchangeMediumToType(medium);
     if (transformedMedium === 'WWW') {
       this.store.dispatch({
@@ -518,8 +510,11 @@ class Server extends EventEmitter {
     // otherwise, use given device_id
     const {csr_path, csr} = csrQuery;
     // For iOS we do not need to confirm the device id, as it never changes unlike android.
-    return (csr_path && csr && query.os != 'iOS'
+    return (
-      ? this.certificateProvider.extractAppNameFromCSR(csr).then((appName) => {
+      csr_path && csr && query.os != 'iOS'
+        ? this.certificateProvider
+            .extractAppNameFromCSR(csr)
+            .then((appName) => {
               return this.certificateProvider.getTargetDeviceId(
                 query.os,
                 appName,

desktop/app/src/ui/components/ContextMenuProvider.tsx

@@ -22,9 +22,8 @@ const Container = styled.div({
 });
 Container.displayName = 'ContextMenuProvider:Container';
 
-export const ContextMenuContext = createContext<ContextMenuManager | undefined>(
+export const ContextMenuContext =
-  undefined,
+  createContext<ContextMenuManager | undefined>(undefined);
-);
 /**
  * Flipper's root is already wrapped with this component, so plugins should not
  * need to use this. ContextMenu is what you probably want to use.

desktop/app/src/ui/components/PopoverProvider.tsx

@@ -63,7 +63,8 @@ const PopoverElement = (props: {
   children: ReactNode;
 }) => {
   const ref = useRef<HTMLDivElement | null>(null);
-  const [dimensions, setDimensions] = useState<{
+  const [dimensions, setDimensions] =
+    useState<{
       width: number;
       height: number;
     } | null>(null);

desktop/app/src/ui/components/Select.tsx

@@ -69,15 +69,8 @@ export default class Select extends Component<{
   };
 
   render() {
-    const {
+    const {className, options, selected, label, grow, disabled, style} =
-      className,
+      this.props;
-      options,
-      selected,
-      label,
-      grow,
-      disabled,
-      style,
-    } = this.props;
 
     let select = (
       <SelectMenu

desktop/app/src/ui/components/StackTrace.tsx

@@ -115,9 +115,9 @@ export default class StackTrace extends Component<{
       return null;
     }
 
-    const columns = (Object.keys(children[0]) as Array<
+    const columns = (
-      keyof Child
+      Object.keys(children[0]) as Array<keyof Child>
-    >).reduce<TableColumns>((acc, cv) => {
+    ).reduce<TableColumns>((acc, cv) => {
       if (cv !== 'isBold') {
         acc[cv] = {
           value: cv,
@@ -131,9 +131,9 @@ export default class StackTrace extends Component<{
       visible: Boolean(columns[key]),
     }));
 
-    const columnSizes = (Object.keys(COLUMNS) as Array<
+    const columnSizes = (
-      keyof typeof COLUMNS
+      Object.keys(COLUMNS) as Array<keyof typeof COLUMNS>
-    >).reduce<TableColumnSizes>((acc, cv: keyof typeof COLUMNS) => {
+    ).reduce<TableColumnSizes>((acc, cv: keyof typeof COLUMNS) => {
       acc[cv] =
         COLUMNS[cv] === 'flex'
           ? 'flex'

desktop/app/src/ui/components/searchable/Searchable.tsx

@@ -208,11 +208,8 @@ export default function Searchable(
               const filters = new Set(
                 savedDefaultFilter.enum.map((filter) => filter.value),
               );
-              savedStateFilters[
+              savedStateFilters[filterIndex].value =
-                filterIndex
+                savedDefaultFilter.value.filter((value) => filters.has(value));
-              ].value = savedDefaultFilter.value.filter((value) =>
-                filters.has(value),
-              );
             }
           });
         }

desktop/app/src/ui/components/searchable/SearchableTable.tsx

@@ -91,12 +91,14 @@ export function rowMatchesSearchTerm(
   );
 }
 
-export const filterRowsFactory = (
+export const filterRowsFactory =
+  (
     filters: Array<Filter>,
     searchTerm: string,
     regexSearch: boolean,
     contentSearch: boolean,
-) => (row: TableBodyRow): boolean =>
+  ) =>
+  (row: TableBodyRow): boolean =>
     rowMatchesFilters(filters, row) &&
     rowMatchesSearchTerm(searchTerm, regexSearch, contentSearch, row);
 

desktop/app/src/ui/components/table/ManagedTable.tsx

@@ -540,8 +540,9 @@ export class ManagedTable extends React.Component<
                 .map((column, index) => ({
                   label: this.props.columns[column].value,
                   click: () => {
-                    const rowId = this.state.highlightedRows.values().next()
+                    const rowId = this.state.highlightedRows
-                      .value;
+                      .values()
+                      .next().value;
                     rowId && this.onCopyCell(rowId, index);
                   },
                 })),
@@ -665,13 +666,8 @@ export class ManagedTable extends React.Component<
   };
 
   render() {
-    const {
+    const {columns, rows, rowLineHeight, hideHeader, horizontallyScrollable} =
-      columns,
+      this.props;
-      rows,
-      rowLineHeight,
-      hideHeader,
-      horizontallyScrollable,
-    } = this.props;
     const {columnOrder, columnSizes} = this.state;
 
     let computedWidth = 0;

desktop/app/src/ui/components/table/ManagedTable_immutable.tsx

@@ -499,8 +499,9 @@ class ManagedTable extends React.Component<
                 .map((column, index) => ({
                   label: this.props.columns[column].value,
                   click: () => {
-                    const rowId = this.state.highlightedRows.values().next()
+                    const rowId = this.state.highlightedRows
-                      .value;
+                      .values()
+                      .next().value;
                     rowId && this.onCopyCell(rowId, index);
                   },
                 })),
@@ -632,13 +633,8 @@ class ManagedTable extends React.Component<
   };
 
   render() {
-    const {
+    const {columns, rows, rowLineHeight, hideHeader, horizontallyScrollable} =
-      columns,
+      this.props;
-      rows,
-      rowLineHeight,
-      hideHeader,
-      horizontallyScrollable,
-    } = this.props;
     const {columnOrder, columnSizes} = this.state;
 
     let computedWidth = 0;

desktop/app/src/utils/CertificateProvider.tsx

@@ -286,11 +286,8 @@ export default class CertificateProvider {
       const deviceIdPromise = appNamePromise.then((app) =>
         this.getTargetAndroidDeviceId(app, destination, csr),
       );
-      return Promise.all([
+      return Promise.all([deviceIdPromise, appNamePromise, this.adb]).then(
-        deviceIdPromise,
+        ([deviceId, appName, adbClient]) =>
-        appNamePromise,
-        this.adb,
-      ]).then(([deviceId, appName, adbClient]) =>
           androidUtil.push(
             adbClient,
             deviceId,
@@ -305,9 +302,8 @@ export default class CertificateProvider {
         (err) => {
           if (os === 'iOS') {
             // Writing directly to FS failed. It's probably a physical device.
-            const relativePathInsideApp = this.getRelativePathInAppContainer(
+            const relativePathInsideApp =
-              destination,
+              this.getRelativePathInAppContainer(destination);
-            );
             return appNamePromise
               .then((appName) => {
                 return this.getTargetiOSDeviceId(appName, destination, csr);

desktop/app/src/utils/__tests__/exportData.node.tsx

@@ -1127,12 +1127,8 @@ const sandyTestPlugin = new _SandyPluginDefinition(
 );
 
 test('Sandy plugins are exported properly', async () => {
-  const {
+  const {client, sendMessage, store, device} =
-    client,
+    await createMockFlipperWithPlugin(sandyTestPlugin);
-    sendMessage,
-    store,
-    device,
-  } = await createMockFlipperWithPlugin(sandyTestPlugin);
 
   // We do select another plugin, to verify that pending message queues are indeed processed before exporting
   store.dispatch(
@@ -1266,8 +1262,7 @@ test('Sandy plugins are imported properly', async () => {
   const data = {
     clients: [
       {
-        id:
+        id: 'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial',
-          'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial',
         query: {
           app: 'TestApp',
           device: 'MockAndroidDevice',
@@ -1288,7 +1283,8 @@ test('Sandy plugins are imported properly', async () => {
     fileVersion: '0.9.99',
     flipperReleaseRevision: undefined,
     pluginStates2: {
-      'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial': {
+      'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial':
+        {
           TestPlugin: {
             otherState: {
               testCount: -3,
@@ -1484,8 +1480,7 @@ test('Sandy plugin with custom import', async () => {
   const data = {
     clients: [
       {
-        id:
+        id: 'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial',
-          'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial',
         query: {
           app: 'TestApp',
           device: 'MockAndroidDevice',
@@ -1506,7 +1501,8 @@ test('Sandy plugin with custom import', async () => {
     fileVersion: '0.9.99',
     flipperReleaseRevision: undefined,
     pluginStates2: {
-      'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial': {
+      'TestApp#Android#MockAndroidDevice#2e52cea6-94b0-4ea1-b9a8-c9135ede14ca-serial':
+        {
           [plugin.id]: {
             count: 4,
           },

desktop/app/src/utils/__tests__/messageQueue.node.tsx

@@ -109,12 +109,8 @@ test('queue - events are processed immediately if plugin is selected', async ()
 });
 
 test('queue - events are NOT processed immediately if plugin is NOT selected (but enabled)', async () => {
-  const {
+  const {store, client, sendMessage, device} =
-    store,
+    await createMockFlipperWithPlugin(TestPlugin);
-    client,
-    sendMessage,
-    device,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
   expect(store.getState().connections.selectedPlugin).not.toBe('TestPlugin');
 
@@ -203,12 +199,8 @@ test('queue - events are NOT processed immediately if plugin is NOT selected (bu
 });
 
 test('queue - events are queued for plugins that are favorite when app is not selected', async () => {
-  const {
+  const {device, store, sendMessage, createClient} =
-    device,
+    await createMockFlipperWithPlugin(TestPlugin);
-    store,
-    sendMessage,
-    createClient,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
   expect(store.getState().connections.selectedPlugin).not.toBe('TestPlugin');
 
@@ -235,13 +227,8 @@ test('queue - events are queued for plugins that are favorite when app is not se
 });
 
 test('queue - events are queued for plugins that are favorite when app is selected on different device', async () => {
-  const {
+  const {client, store, sendMessage, createDevice, createClient} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    store,
-    sendMessage,
-    createDevice,
-    createClient,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
   expect(store.getState().connections.selectedPlugin).not.toBe('TestPlugin');
 
@@ -282,12 +269,8 @@ test('queue - events are queued for plugins that are favorite when app is select
 });
 
 test('queue - events processing will be paused', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -330,12 +313,8 @@ test('queue - events processing will be paused', async () => {
 });
 
 test('queue - messages that arrive during processing will be queued', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -380,12 +359,8 @@ test('queue - messages that arrive during processing will be queued', async () =
 });
 
 test('queue - processing can be cancelled', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -415,12 +390,8 @@ test('queue - processing can be cancelled', async () => {
 });
 
 test('queue - make sure resetting plugin state clears the message queue', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -486,12 +457,8 @@ test('client - incoming messages are buffered and flushed together', async () =>
     static persistedStateReducer = jest.fn();
   }
 
-  const {
+  const {client, store, device, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    store,
-    device,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   store.dispatch(registerPlugins([StubDeviceLogs]));
@@ -646,12 +613,8 @@ test('client - incoming messages are buffered and flushed together', async () =>
 });
 
 test('queue - messages that have not yet flushed be lost when disabling the plugin', async () => {
-  const {
+  const {client, store, sendMessage, pluginKey} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    store,
-    sendMessage,
-    pluginKey,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});

desktop/app/src/utils/__tests__/messageQueueSandy.node.tsx

@@ -116,12 +116,8 @@ test('queue - events are processed immediately if plugin is selected', async ()
 });
 
 test('queue - events are NOT processed immediately if plugin is NOT selected (but enabled)', async () => {
-  const {
+  const {store, client, sendMessage, device} =
-    store,
+    await createMockFlipperWithPlugin(TestPlugin);
-    client,
-    sendMessage,
-    device,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
   expect(store.getState().connections.selectedPlugin).not.toBe('TestPlugin');
 
@@ -260,13 +256,8 @@ test('queue - events ARE processed immediately if plugin is NOT selected / enabl
 });
 
 test('queue - events are queued for plugins that are favorite when app is not selected', async () => {
-  const {
+  const {client, device, store, sendMessage, createClient} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-    createClient,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
   expect(store.getState().connections.selectedPlugin).not.toBe('TestPlugin');
 
@@ -293,13 +284,8 @@ test('queue - events are queued for plugins that are favorite when app is not se
 });
 
 test('queue - events are queued for plugins that are favorite when app is selected on different device', async () => {
-  const {
+  const {client, store, sendMessage, createDevice, createClient} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    store,
-    sendMessage,
-    createDevice,
-    createClient,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
   expect(store.getState().connections.selectedPlugin).not.toBe('TestPlugin');
 
@@ -340,12 +326,8 @@ test('queue - events are queued for plugins that are favorite when app is select
 });
 
 test('queue - events processing will be paused', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -390,12 +372,8 @@ test('queue - events processing will be paused', async () => {
 });
 
 test('queue - messages that arrive during processing will be queued', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -446,12 +424,8 @@ test('queue - messages that arrive during processing will be queued', async () =
 });
 
 test('queue - processing can be cancelled', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -487,12 +461,8 @@ test('queue - processing can be cancelled', async () => {
 });
 
 test('queue - make sure resetting plugin state clears the message queue', async () => {
-  const {
+  const {client, device, store, sendMessage} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    device,
-    store,
-    sendMessage,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});
@@ -522,13 +492,8 @@ test('client - incoming messages are buffered and flushed together', async () =>
     static persistedStateReducer = jest.fn();
   }
 
-  const {
+  const {client, store, device, sendMessage, pluginKey} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    store,
-    device,
-    sendMessage,
-    pluginKey,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   store.dispatch(registerPlugins([StubDeviceLogs]));
@@ -687,12 +652,8 @@ test('client - incoming messages are buffered and flushed together', async () =>
 });
 
 test('queue - messages that have not yet flushed be lost when disabling the plugin', async () => {
-  const {
+  const {client, store, sendMessage, pluginKey} =
-    client,
+    await createMockFlipperWithPlugin(TestPlugin);
-    store,
-    sendMessage,
-    pluginKey,
-  } = await createMockFlipperWithPlugin(TestPlugin);
   selectDeviceLogs(store);
 
   sendMessage('inc', {});

desktop/app/src/utils/exportData.tsx

@@ -201,13 +201,8 @@ export function processPluginStates(
 export function processNotificationStates(
   options: ProcessNotificationStatesOptions,
 ): Array<PluginNotification> {
-  const {
+  const {clients, serial, allActiveNotifications, devicePlugins, statusUpdate} =
-    clients,
+    options;
-    serial,
-    allActiveNotifications,
-    devicePlugins,
-    statusUpdate,
-  } = options;
   statusUpdate &&
     statusUpdate('Filtering the notifications for the filtered Clients...');
   const activeNotifications = allActiveNotifications.filter((notif) => {

desktop/app/src/utils/icons.ts

@@ -34,9 +34,10 @@ export function getIcons(): Icons {
 
 // Takes a string like 'star', or 'star-outline', and converts it to
 // {trimmedName: 'star', variant: 'filled'} or {trimmedName: 'star', variant: 'outline'}
-function getIconPartsFromName(
+function getIconPartsFromName(icon: string): {
-  icon: string,
+  trimmedName: string;
-): {trimmedName: string; variant: 'outline' | 'filled'} {
+  variant: 'outline' | 'filled';
+} {
   const isOutlineVersion = icon.endsWith('-outline');
   const trimmedName = isOutlineVersion ? icon.replace('-outline', '') : icon;
   const variant = isOutlineVersion ? 'outline' : 'filled';

desktop/app/src/utils/js-client-server-utils/serverUtils.tsx

@@ -157,7 +157,8 @@ export function launchJsEmulator(url: string, height: number, width: number) {
 }
 
 export class JSClientFlipperConnection<M>
-  implements FlipperClientConnection<string, M> {
+  implements FlipperClientConnection<string, M>
+{
   webContentsId: number;
   connStatusSubscribers: Set<ISubscriber<ConnectionStatus>> = new Set();
   connStatus: ConnectionStatus;

desktop/app/src/utils/js-client-server-utils/websocketClientFlipperConnection.tsx

@@ -13,7 +13,8 @@ import {Payload, ConnectionStatus, ISubscriber} from 'rsocket-types';
 import WebSocket from 'ws';
 
 export class WebsocketClientFlipperConnection<M>
-  implements FlipperClientConnection<string, M> {
+  implements FlipperClientConnection<string, M>
+{
   websocket: WebSocket;
   connStatusSubscribers: Set<ISubscriber<ConnectionStatus>> = new Set();
   connStatus: ConnectionStatus;

desktop/app/src/utils/packageMetadata.tsx

@@ -26,13 +26,12 @@ const getPackageJSON = async () => {
   return JSON.parse(content);
 };
 
-export const readCurrentRevision: () => Promise<
+export const readCurrentRevision: () => Promise<string | undefined> =
-  string | undefined
+  lodash.memoize(async () => {
-> = lodash.memoize(async () => {
     // This is provided as part of the bundling process for headless.
     if (global.__REVISION__) {
       return global.__REVISION__;
     }
     const json = await getPackageJSON();
     return json.revision;
-});
+  });

desktop/app/src/utils/self-inspection/selfInspectionClient.tsx

@@ -26,7 +26,8 @@ interface IFutureSubject<T> {
 
 export class SelfInspectionFlipperClient<M>
   extends FlipperClient
-  implements FlipperClientConnection<string, M> {
+  implements FlipperClientConnection<string, M>
+{
   connStatusSubscribers: Set<ISubscriber<ConnectionStatus>> = new Set();
   connStatus: ConnectionStatus = {kind: 'CONNECTED'};
 

desktop/app/src/utils/serialization.tsx

@@ -15,12 +15,9 @@ export async function serialize(
   statusUpdate?: (msg: string) => void,
   statusMsg?: string,
 ): Promise<string> {
-  return makeObjectSerializable(
+  return makeObjectSerializable(obj, idler, statusUpdate, statusMsg).then(
-    obj,
+    (obj) => JSON.stringify(obj),
-    idler,
+  );
-    statusUpdate,
-    statusMsg,
-  ).then((obj) => JSON.stringify(obj));
 }
 
 export function deserialize(str: string): any {

desktop/app/src/utils/sideEffect.tsx

@@ -25,7 +25,7 @@ import {shallowEqual} from 'react-redux';
 export function sideEffect<
   Store extends ReduxStore<any, any>,
   V,
-  State = Store extends ReduxStore<infer S, any> ? S : never
+  State = Store extends ReduxStore<infer S, any> ? S : never,
 >(
   store: Store,
   options: {

desktop/babel-transformer/package.json

@@ -32,7 +32,7 @@
   "devDependencies": {
     "@types/jest": "26.0.23",
     "jest": "^26.6.3",
-    "prettier": "^2.2.1",
+    "prettier": "^2.3.0",
     "rimraf": "^3.0.2",
     "ts-jest": "^26.5.6",
     "ts-node": "^9.1.1",

desktop/doctor/package.json

@@ -17,7 +17,7 @@
     "eslint-plugin-prettier": "^3.4.0",
     "eslint-plugin-react": "^7.23.2",
     "jest": "^26.6.3",
-    "prettier": "^2.2.1",
+    "prettier": "^2.3.0",
     "ts-jest": "^26.5.6",
     "tslint-config-prettier": "^1.18.0",
     "typescript": "^4.2.4"

desktop/doctor/src/index.ts

@@ -301,9 +301,8 @@ export async function runHealthchecks(): Promise<
 > {
   const environmentInfo = await getEnvInfo();
   const healthchecks: Healthchecks = getHealthchecks();
-  const results: Array<
+  const results: Array<CategoryResult | SkippedHealthcheckCategory> =
-    CategoryResult | SkippedHealthcheckCategory
+    await Promise.all(
-  > = await Promise.all(
       Object.entries(healthchecks).map(async ([key, category]) => {
         if (category.isSkipped) {
           return category;

desktop/eslint-plugin-flipper/package.json

@@ -18,7 +18,7 @@
     "@typescript-eslint/parser": "^4.22.0",
     "flipper-test-utils": "0.0.0",
     "jest": "^26.6.3",
-    "prettier": "^2.2.1",
+    "prettier": "^2.3.0",
     "rimraf": "^3.0.2",
     "ts-jest": "^26.5.6",
     "ts-node": "^9.1.1",

desktop/flipper-plugin/src/__tests__/test-utils-device.node.tsx

@@ -67,9 +67,8 @@ test('it can start a device plugin and listen to lifecycle events', () => {
 });
 
 test('it can render a device plugin', () => {
-  const {renderer, instance, sendLogEntry} = TestUtils.renderDevicePlugin(
+  const {renderer, instance, sendLogEntry} =
-    testPlugin,
+    TestUtils.renderDevicePlugin(testPlugin);
-  );
 
   expect(renderer.baseElement).toMatchInlineSnapshot(`
     <body>

desktop/flipper-plugin/src/data-source/DataSource.tsx

@@ -86,7 +86,7 @@ type OutputChange =
 export class DataSource<
   T = any,
   KEY extends keyof T = any,
-  KEY_TYPE extends string | number | never = ExtractKeyType<T, KEY>
+  KEY_TYPE extends string | number | never = ExtractKeyType<T, KEY>,
 > {
   private nextId = 0;
   private _records: Entry<T>[] = [];

desktop/flipper-plugin/src/plugin/MenuEntry.tsx

@@ -54,9 +54,9 @@ export const buildInMenuEntries = {
 
 export function normalizeMenuEntry(entry: MenuEntry): NormalizedMenuEntry;
 export function normalizeMenuEntry(entry: any): NormalizedMenuEntry {
-  const builtInEntry:
+  const builtInEntry: NormalizedMenuEntry | undefined = (
-    | NormalizedMenuEntry
+    buildInMenuEntries as any
-    | undefined = (buildInMenuEntries as any)[entry.action];
+  )[entry.action];
   return builtInEntry
     ? {...builtInEntry, ...entry}
     : {

desktop/flipper-plugin/src/plugin/Plugin.tsx

@@ -27,7 +27,7 @@ type Message = {
  */
 export interface PluginClient<
   Events extends EventsContract = {},
-  Methods extends MethodsContract = {}
+  Methods extends MethodsContract = {},
 > extends BasePluginClient {
   /**
    * Identifier that uniquely identifies the connected application
@@ -128,7 +128,7 @@ export interface RealFlipperClient {
 
 export type PluginFactory<
   Events extends EventsContract,
-  Methods extends MethodsContract
+  Methods extends MethodsContract,
 > = (client: PluginClient<Events, Methods>) => object;
 
 export type FlipperPluginComponent = React.FC<{}>;

desktop/flipper-plugin/src/plugin/PluginContext.tsx

@@ -11,9 +11,10 @@ import {createContext, useContext} from 'react';
 import {SandyPluginInstance, PluginFactory} from './Plugin';
 import {SandyDevicePluginInstance, DevicePluginFactory} from './DevicePlugin';
 
-export const SandyPluginContext = createContext<
+export const SandyPluginContext =
-  SandyPluginInstance | SandyDevicePluginInstance | undefined
+  createContext<SandyPluginInstance | SandyDevicePluginInstance | undefined>(
->(undefined);
+    undefined,
+  );
 
 export function usePluginInstance():
   | SandyPluginInstance
@@ -26,7 +27,7 @@ export function usePluginInstance():
 }
 
 export function usePlugin<
-  Factory extends PluginFactory<any, any> | DevicePluginFactory
+  Factory extends PluginFactory<any, any> | DevicePluginFactory,
 >(plugin: Factory): ReturnType<Factory> {
   const pluginInstance = usePluginInstance();
   // In principle we don't *need* the plugin, but having it passed it makes sure the

desktop/flipper-plugin/src/test-utils/test-utils.tsx

@@ -60,15 +60,13 @@ type ExtractClientType<Module extends FlipperPluginModule<any>> = Parameters<
   Module['plugin']
 >[0];
 
-type ExtractMethodsType<
+type ExtractMethodsType<Module extends FlipperPluginModule<any>> =
-  Module extends FlipperPluginModule<any>
+  ExtractClientType<Module> extends PluginClient<any, infer Methods>
-> = ExtractClientType<Module> extends PluginClient<any, infer Methods>
     ? Methods
     : never;
 
-type ExtractEventsType<
+type ExtractEventsType<Module extends FlipperPluginModule<any>> =
-  Module extends FlipperPluginModule<any>
+  ExtractClientType<Module> extends PluginClient<infer Events, any>
-> = ExtractClientType<Module> extends PluginClient<infer Events, any>
     ? Events
     : never;
 

desktop/flipper-plugin/src/ui/DataList.tsx

@@ -78,7 +78,7 @@ export type DataListProps<T extends Item> = DataListBaseProps<T> &
   Omit<DataTableProps<T>, 'records' | 'dataSource' | 'columns' | 'onSelect'>;
 
 export const DataList: React.FC<DataListProps<any>> = function DataList<
-  T extends Item
+  T extends Item,
 >({
   selection: baseSelection,
   onSelect,

desktop/flipper-plugin/src/ui/Interactive.tsx

@@ -404,11 +404,8 @@ export class Interactive extends React.Component<
   }
 
   calculateResize(event: MouseEvent) {
-    const {
+    const {resizingInitialCursor, resizingInitialRect, resizingSides} =
-      resizingInitialCursor,
+      this.state;
-      resizingInitialRect,
-      resizingSides,
-    } = this.state;
 
     const deltaLeft = resizingInitialCursor!.left - event.clientX;
     const deltaTop = resizingInitialCursor!.top - event.clientY;
@@ -517,9 +514,7 @@ export class Interactive extends React.Component<
     }
   }
 
-  checkIfResizable(
+  checkIfResizable(event: MouseEvent):
-    event: MouseEvent,
-  ):
     | {
         left: boolean;
         right: boolean;

desktop/flipper-plugin/src/ui/Layout.tsx

@@ -190,14 +190,8 @@ function renderSplitLayout(
     child2 = <Empty />;
   }
   if ('resizable' in props && props.resizable) {
-    const {
+    const {width, height, minHeight, minWidth, maxHeight, maxWidth} =
-      width,
+      props as any;
-      height,
-      minHeight,
-      minWidth,
-      maxHeight,
-      maxWidth,
-    } = props as any;
     const sizeProps =
       direction === 'column'
         ? ({

desktop/flipper-plugin/src/ui/Panel.tsx

@@ -94,7 +94,8 @@ const StyledCollapse = styled(Collapse)({
   '& > .ant-collapse-item': {
     borderBottom: 'none',
   },
-  '& > .ant-collapse-item > .ant-collapse-content > .ant-collapse-content-box': {
+  '& > .ant-collapse-item > .ant-collapse-content > .ant-collapse-content-box':
+    {
       padding: 0,
     },
 });

desktop/flipper-plugin/src/ui/data-inspector/DataInspectorNode.tsx

@@ -326,18 +326,14 @@ export const DataInspectorNode: React.FC<DataInspectorProps> = memo(
       [extractValueProp],
     );
 
-    const res = useMemo(() => extractValue(data, depth, path), [
+    const res = useMemo(
-      extractValue,
+      () => extractValue(data, depth, path),
-      data,
+      [extractValue, data, depth, path],
-      depth,
+    );
-      path,
+    const resDiff = useMemo(
-    ]);
+      () => extractValue(diff, depth, path),
-    const resDiff = useMemo(() => extractValue(diff, depth, path), [
+      [extractValue, diff, depth, path],
-      extractValue,
+    );
-      diff,
-      depth,
-      path,
-    ]);
     const ancestry = useMemo(
       () => (res ? parentAncestry!.concat([res.value]) : []),
       [parentAncestry, res?.value],

desktop/flipper-plugin/src/utils/createTablePlugin.tsx

@@ -18,9 +18,7 @@ import {MasterDetail} from '../ui/MasterDetail';
 import {createDataSource} from '../state/createDataSource';
 
 type PluginResult<Raw, Row> = {
-  plugin(
+  plugin(client: PluginClient<Record<string, Raw | {}>>): {
-    client: PluginClient<Record<string, Raw | {}>>,
-  ): {
     rows: DataSource<Row>;
   };
   Component(): React.ReactElement;
@@ -49,7 +47,7 @@ export function createTablePlugin<Row extends object>(props: {
 }): PluginResult<Row, Row>;
 export function createTablePlugin<
   Raw extends object,
-  Row extends object = Raw
+  Row extends object = Raw,
 >(props: {
   buildRow: (record: Raw) => Row;
   method: string;
@@ -63,7 +61,7 @@ export function createTablePlugin<
   Raw extends object,
   Method extends string,
   ResetMethod extends string,
-  Row extends object = Raw
+  Row extends object = Raw,
 >(props: {
   method: Method;
   resetMethod?: ResetMethod;
@@ -89,7 +87,7 @@ export function createTablePlugin<
       }
       const record = props.buildRow
         ? props.buildRow(event)
-        : ((event as any) as Row);
+        : (event as any as Row);
       if (props.key) {
         rows.upsert(record);
       } else {

desktop/flipper-plugin/src/utils/parseColor.tsx

@@ -7,9 +7,7 @@
  * @format
  */
 
-export function parseColor(
+export function parseColor(val: string | number):
-  val: string | number,
-):
   | {
       r: number;
       g: number;

desktop/flipper-plugin/src/utils/urlRegex.tsx

@@ -9,4 +9,5 @@
 
 // Source: https://github.com/sindresorhus/linkify-urls/blob/e0cf2a2d51dc8f5f95d93f97ecb1cc804cc9e6be/index.js#L5
 // n.b. no /g flag, as that makes the regex stateful! Which is not needed for splitting
-export const urlRegex = /((?<!\+)(?:https?(?::\/\/))(?:www\.)?(?:[a-zA-Z\d-_.]+(?:(?:\.|@)[a-zA-Z\d]{2,})|localhost)(?:(?:[-a-zA-Z\d:%_+.~#*$!?&//=@]*)(?:[,](?![\s]))*)*)/;
+export const urlRegex =
+  /((?<!\+)(?:https?(?::\/\/))(?:www\.)?(?:[a-zA-Z\d-_.]+(?:(?:\.|@)[a-zA-Z\d]{2,})|localhost)(?:(?:[-a-zA-Z\d:%_+.~#*$!?&//=@]*)(?:[,](?![\s]))*)*)/;

desktop/package.json

@@ -170,7 +170,7 @@
     "p-filter": "^2.1.0",
     "p-map": "^4.0.0",
     "patch-package": "^6.4.7",
-    "prettier": "^2.2.1",
+    "prettier": "^2.3.0",
     "pretty-format": "^26.1.0",
     "promisify-child-process": "^4.1.0",
     "react-async": "^10.0.0",

desktop/pkg-lib/package.json

@@ -25,7 +25,7 @@
     "globby": "^11.0.3",
     "jest": "^26.6.3",
     "mock-fs": "^4.14.0",
-    "prettier": "^2.2.1",
+    "prettier": "^2.3.0",
     "rimraf": "^3.0.2",
     "ts-jest": "^26.5.6",
     "ts-node": "^9.1.1",

desktop/pkg/package.json

@@ -36,7 +36,7 @@
     "flipper-test-utils": "0.0.0",
     "globby": "^11.0.3",
     "jest": "^26.6.3",
-    "prettier": "^2.2.1",
+    "prettier": "^2.3.0",
     "rimraf": "^3.0.2",
     "ts-jest": "^26.5.6",
     "ts-node": "^9.1.1",

desktop/plugins/public/cpu/index.tsx

@@ -98,10 +98,8 @@ export function devicePlugin(client: PluginClient<{}, {}>) {
     displayCPUDetail: true,
   });
 
-  const updateCoreFrequency: (
+  const updateCoreFrequency: (core: number, type: string) => Promise<void> =
-    core: number,
+    async (core: number, type: string) => {
-    type: string,
-  ) => Promise<void> = async (core: number, type: string) => {
       const output = await executeShell(
         'cat /sys/devices/system/cpu/cpu' + core + '/cpufreq/' + type,
       );

desktop/plugins/public/databases/DatabasesPlugin.tsx

@@ -332,9 +332,10 @@ const FavoritesMenu = React.memo(
     favorites: string[];
     onClick: (value: string) => void;
   }) => {
-    const onMenuClick = useCallback((p: any) => onClick(p.key as string), [
+    const onMenuClick = useCallback(
-      onClick,
+      (p: any) => onClick(p.key as string),
-    ]);
+      [onClick],
+    );
     return (
       <Menu>
         {favorites.map((q) => (
@@ -488,12 +489,8 @@ export function Component() {
 
   const onRowEdited = useCallback(
     (change: {[key: string]: string | null}) => {
-      const {
+      const {selectedDatabaseTable, currentStructure, viewMode, currentPage} =
-        selectedDatabaseTable,
+        instance.state.get();
-        currentStructure,
-        viewMode,
-        currentPage,
-      } = instance.state.get();
       const highlightedRowIdx = currentPage?.highlightedRows[0] ?? -1;
       const row =
         highlightedRowIdx >= 0

desktop/plugins/public/layout/Inspector.tsx

@@ -197,9 +197,8 @@ export default class Inspector extends Component<Props, State> {
       selectedElement !== prevProps.selectedElement
     ) {
       // selected element in non-AX tree changed, find linked element in AX tree
-      const newlySelectedElem = this.props.persistedState.elements[
+      const newlySelectedElem =
-        selectedElement
+        this.props.persistedState.elements[selectedElement];
-      ];
       if (newlySelectedElem) {
         this.props.onSelect(
           newlySelectedElem.extraInfo
@@ -213,9 +212,8 @@ export default class Inspector extends Component<Props, State> {
       selectedAXElement !== prevProps.selectedAXElement
     ) {
       // selected element in AX tree changed, find linked element in non-AX tree
-      const newlySelectedAXElem = this.props.persistedState.AXelements[
+      const newlySelectedAXElem =
-        selectedAXElement
+        this.props.persistedState.AXelements[selectedAXElement];
-      ];
       if (newlySelectedAXElem) {
         this.props.onSelect(
           newlySelectedAXElem.extraInfo
@@ -310,16 +308,12 @@ export default class Inspector extends Component<Props, State> {
   ): Promise<Array<Element>> {
     if (ids.length > 0 && this.props.client.isConnected) {
       const {forAccessibilityEvent} = options;
-      const {
+      const {elements}: {elements: Array<Element>} =
-        elements,
+        await this.props.client.call(this.call().GET_NODES, {
-      }: {elements: Array<Element>} = await this.props.client.call(
-        this.call().GET_NODES,
-        {
           ids,
           forAccessibilityEvent,
           selected: false,
-        },
+        });
-      );
       elements.forEach((e) => this.updateElement(e.id, e));
       return elements;
     } else {

desktop/plugins/public/logs/__tests__/logs.node.tsx

@@ -86,13 +86,8 @@ test('it will merge equal rows', () => {
 });
 
 test('it supports deeplink and select nodes + navigating to bottom', async () => {
-  const {
+  const {instance, sendLogEntry, triggerDeepLink, act, triggerMenuEntry} =
-    instance,
+    TestUtils.renderDevicePlugin(LogsPlugin);
-    sendLogEntry,
-    triggerDeepLink,
-    act,
-    triggerMenuEntry,
-  } = TestUtils.renderDevicePlugin(LogsPlugin);
 
   sendLogEntry(entry1);
   sendLogEntry(entry2);
@@ -126,11 +121,8 @@ test('it supports deeplink and select nodes + navigating to bottom', async () =>
 });
 
 test('export / import plugin does work', async () => {
-  const {
+  const {instance, exportStateAsync, sendLogEntry} =
-    instance,
+    TestUtils.startDevicePlugin(LogsPlugin);
-    exportStateAsync,
-    sendLogEntry,
-  } = TestUtils.startDevicePlugin(LogsPlugin);
 
   sendLogEntry(entry1);
   sendLogEntry(entry2);

desktop/plugins/public/logs/index.tsx

@@ -116,9 +116,8 @@ export function devicePlugin(client: DevicePluginClient) {
     persist: 'logs',
   });
   const isPaused = createState(true);
-  const tableManagerRef = createRef<
+  const tableManagerRef =
-    undefined | DataTableManager<ExtendedLogEntry>
+    createRef<undefined | DataTableManager<ExtendedLogEntry>>();
-  >();
 
   client.onDeepLink((payload: unknown) => {
     if (typeof payload === 'string') {

desktop/plugins/public/navigation/components/RequiredParametersDialog.tsx

@@ -30,9 +30,8 @@ type Props = {
 
 export default (props: Props) => {
   const {onHide, onSubmit, uri, requiredParameters} = props;
-  const {isValid, values, setValuesArray} = useRequiredParameterFormValidator(
+  const {isValid, values, setValuesArray} =
-    requiredParameters,
+    useRequiredParameterFormValidator(requiredParameters);
-  );
   return (
     <Modal
       visible

desktop/plugins/public/navigation/components/SearchBar.tsx

@@ -95,12 +95,8 @@ class SearchBar extends Component<Props, State> {
 
   render() {
     const {bookmarks, providers} = this.props;
-    const {
+    const {autoCompleteSheetOpen, inputFocused, searchInputValue, query} =
-      autoCompleteSheetOpen,
+      this.state;
-      inputFocused,
-      searchInputValue,
-      query,
-    } = this.state;
     return (
       <ToolbarContainer>
         <Toolbar>

desktop/plugins/public/network/ProtobufDefinitionsRepository.tsx

@@ -21,7 +21,8 @@ export class ProtobufDefinitionsRepository {
 
   public static getInstance(): ProtobufDefinitionsRepository {
     if (!ProtobufDefinitionsRepository.instance) {
-      ProtobufDefinitionsRepository.instance = new ProtobufDefinitionsRepository();
+      ProtobufDefinitionsRepository.instance =
+        new ProtobufDefinitionsRepository();
     }
     return ProtobufDefinitionsRepository.instance;
   }

desktop/plugins/public/network/RequestDetails.tsx

@@ -668,14 +668,16 @@ class BinaryFormatter {
 }
 
 class ProtobufFormatter {
-  private protobufDefinitionRepository = ProtobufDefinitionsRepository.getInstance();
+  private protobufDefinitionRepository =
+    ProtobufDefinitionsRepository.getInstance();
 
   formatRequest(request: Request) {
     if (
       getHeaderValue(request.requestHeaders, 'content-type') ===
       'application/x-protobuf'
     ) {
-      const protobufDefinition = this.protobufDefinitionRepository.getRequestType(
+      const protobufDefinition =
+        this.protobufDefinitionRepository.getRequestType(
           request.method,
           request.url,
         );
@@ -708,7 +710,8 @@ class ProtobufFormatter {
         'application/x-protobuf' ||
       request.url.endsWith('.proto')
     ) {
-      const protobufDefinition = this.protobufDefinitionRepository.getResponseType(
+      const protobufDefinition =
+        this.protobufDefinitionRepository.getResponseType(
           request.method,
           request.url,
         );

desktop/plugins/public/network/__tests__/customheaders.node.tsx

@@ -11,13 +11,8 @@ import {TestUtils} from 'flipper-plugin';
 import * as NetworkPlugin from '../index';
 
 test('Can handle custom headers', async () => {
-  const {
+  const {instance, sendEvent, act, renderer, exportState} =
-    instance,
+    TestUtils.renderPlugin(NetworkPlugin);
-    sendEvent,
-    act,
-    renderer,
-    exportState,
-  } = TestUtils.renderPlugin(NetworkPlugin);
 
   act(() => {
     sendEvent('newRequest', {

desktop/plugins/public/network/request-mocking/ManageMockResponsePanel.tsx

@@ -90,9 +90,10 @@ export function ManageMockResponsePanel(props: Props) {
       return returnValue;
     });
   }, [props.routes, selectedIdAtom]);
-  const duplicatedIds = useMemo(() => _duplicateIds(props.routes), [
+  const duplicatedIds = useMemo(
-    props.routes,
+    () => _duplicateIds(props.routes),
-  ]);
+    [props.routes],
+  );
 
   const items: RouteItem[] = Object.entries(props.routes).map(
     ([id, route]) => ({

desktop/plugins/public/seamammals/src/__tests__/seamammals.spec.tsx

@@ -65,13 +65,8 @@ test('It can store rows', () => {
 });
 
 test('It can have selection and render details', async () => {
-  const {
+  const {instance, renderer, act, sendEvent, exportState} =
-    instance,
+    TestUtils.renderPlugin(MammalsPlugin);
-    renderer,
-    act,
-    sendEvent,
-    exportState,
-  } = TestUtils.renderPlugin(MammalsPlugin);
 
   expect(instance.rows.get()).toEqual({});
   expect(instance.selectedID.get()).toBeNull();

desktop/scripts/build-release.ts

@@ -160,7 +160,7 @@ async function afterPack(context: AfterPackContext) {
   // and property names being present.
   type Mutable<T> = {-readonly [P in keyof T]: T[P]};
   const originalPackager = Object.assign({}, context.packager);
-  const packager = (context.packager as unknown) as WinPackager;
+  const packager = context.packager as unknown as WinPackager;
   const appInfo: Mutable<AppInfo> = packager.appInfo;
   const exeFileName = `${packager.appInfo.productFilename}.exe`;
   appInfo.version = FIX_RELEASE_VERSION;

desktop/scripts/build-utils.ts

@@ -174,7 +174,8 @@ export async function compileRenderer(buildFolder: string) {
 
 export async function compileMain() {
   const out = path.join(staticDir, 'main.bundle.js');
-  process.env.FLIPPER_ELECTRON_VERSION = require('electron/package.json').version;
+  process.env.FLIPPER_ELECTRON_VERSION =
+    require('electron/package.json').version;
   console.log('⚙️  Compiling main bundle...');
   try {
     const config = Object.assign({}, await Metro.loadConfig(), {

desktop/yarn.lock

@@ -10230,10 +10230,10 @@ prettier@^1.14.2:
   resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.19.1.tgz#f7d7f5ff8a9cd872a7be4ca142095956a60797cb"
   integrity sha512-s7PoyDv/II1ObgQunCbB9PdLmUcBZcnWOcxDh7O0N/UwDEsHyqkW+Qh28jW+mVuCdx7gLB0BotYI1Y6uI9iyew==
 
-prettier@^2.2.1:
+prettier@^2.3.0:
-  version "2.2.1"
+  version "2.3.0"
-  resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.2.1.tgz#795a1a78dd52f073da0cd42b21f9c91381923ff5"
+  resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.3.0.tgz#b6a5bf1284026ae640f17f7ff5658a7567fc0d18"
-  integrity sha512-PqyhM2yCjg/oKkFPtTGUojv7gnZAoG80ttl45O6x2Ug/rMJw4wcc9k6aaf2hibP7BGVCCM33gZoGjyvt9mm16Q==
+  integrity sha512-kXtO4s0Lz/DW/IJ9QdWhAf7/NmPWQXkFr/r/WkR3vyI+0v8amTDxiaQSLzs8NBlytfLWX/7uQUMIW677yLKl4w==
 
 pretty-format@^25.5.0:
   version "25.5.0"