From 6561bc8f16a5e4e18dca0c6eac89b07b42b13941 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Wielg=C3=B3rski?= Date: Thu, 23 Jul 2020 13:45:37 -0700 Subject: [PATCH] Added connection between InAppErrorReporter and Flipper Desktop App via Layout Plugin Summary: Created functionality which allows user to open clicked file from inAppErrorReporter. Created "iface" interface for openInIDE API and created default implementation which indicates that openInIDE is not supported. Created "impl" implementation specifically for fb4a. Reviewed By: arpitratan Differential Revision: D22642497 fbshipit-source-id: 7b3011c128a479e556b869fcc8c4147e153caf71 --- .../plugins/inspector/InspectorFlipperPlugin.java | 12 ++++++++++-- desktop/app/src/fb-stubs/FileResolver.tsx | 4 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java index 95d6a0187..5b7eeaef5 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java @@ -38,9 +38,17 @@ public class InspectorFlipperPlugin implements FlipperPlugin { private boolean mShowLithoAccessibilitySettings; public enum IDE { - diffusion, + DIFFUSION, AS, - VSCode + VSCODE; + + public static IDE fromString(final String ide) { + try { + return IDE.valueOf(ide); + } catch (IllegalArgumentException e) { + return IDE.AS; // default value + } + } } /** An interface for extensions to the Inspector Flipper plugin */ diff --git a/desktop/app/src/fb-stubs/FileResolver.tsx b/desktop/app/src/fb-stubs/FileResolver.tsx index f92daa750..475339845 100644 --- a/desktop/app/src/fb-stubs/FileResolver.tsx +++ b/desktop/app/src/fb-stubs/FileResolver.tsx @@ -9,8 +9,8 @@ export enum IDE { 'AS', - 'VSCode', - 'XCode', + 'VSCODE', + 'XCODE', } export async function resolveFullPathsFromMyles(