From 655d856d1c89df41a00cfa6e53917ce4e3301aa7 Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Tue, 5 May 2020 04:04:55 -0700 Subject: [PATCH] Fixed broken timeline layout Summary: Changelog: Fixed broken layout of timeline in QPL plugin Reviewed By: passy Differential Revision: D21383013 fbshipit-source-id: 95fbe2681ff27dff827c742f11192c1d07ad021c --- desktop/app/src/ui/components/Layout.tsx | 4 ++-- desktop/app/src/ui/components/table/ManagedTable.tsx | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/desktop/app/src/ui/components/Layout.tsx b/desktop/app/src/ui/components/Layout.tsx index 7fa40f582..a0e11b75b 100644 --- a/desktop/app/src/ui/components/Layout.tsx +++ b/desktop/app/src/ui/components/Layout.tsx @@ -51,8 +51,8 @@ const Layout: React.FC< children: [React.ReactNode, React.ReactNode]; } & Props > = ({children, ...props}) => { - if (children.length > 2) { - throw new Error('VerticalContainer expects exactly 2 children'); + if (children.length !== 2) { + throw new Error('Layout expects exactly 2 children'); } const top = children[0]; const main = children[1]; diff --git a/desktop/app/src/ui/components/table/ManagedTable.tsx b/desktop/app/src/ui/components/table/ManagedTable.tsx index 8914c3c65..3a678745d 100644 --- a/desktop/app/src/ui/components/table/ManagedTable.tsx +++ b/desktop/app/src/ui/components/table/ManagedTable.tsx @@ -151,6 +151,7 @@ type ManagedTableState = { const Container = styled(FlexColumn)<{canOverflow?: boolean}>((props) => ({ overflow: props.canOverflow ? 'scroll' : 'visible', flexGrow: 1, + height: '100%', })); Container.displayName = 'ManagedTable:Container';