Remove plugin bundling

Summary: Remove the notion of bundled plugins

Reviewed By: lblasa

Differential Revision: D39308888

fbshipit-source-id: aa88ddbf2801ad1da95f89e4c761259b697b0d66

desktop/flipper-ui-core/src/chrome/PluginActions.tsx

@@ -13,7 +13,7 @@ import {
   PlusOutlined,
 } from '@ant-design/icons';
 import {Alert, Button} from 'antd';
-import {BundledPluginDetails, DownloadablePluginDetails} from 'flipper-common';
+import {DownloadablePluginDetails} from 'flipper-common';
 import React, {useMemo} from 'react';
 import {useCallback} from 'react';
 import {useDispatch, useSelector} from 'react-redux';
@@ -86,16 +86,12 @@ function InstallButton({
   plugin,
   type = 'primary',
 }: {
-  plugin: DownloadablePluginDetails | BundledPluginDetails;
+  plugin: DownloadablePluginDetails;
   type: 'link' | 'primary';
 }) {
   const dispatch = useDispatch();
   const installPlugin = useCallback(() => {
-    if (plugin.isBundled) {
-      dispatch(loadPlugin({plugin, enable: true, notifyIfFailed: true}));
-    } else {
-      dispatch(startPluginDownload({plugin, startedByUser: true}));
-    }
+    dispatch(startPluginDownload({plugin, startedByUser: true}));
   }, [plugin, dispatch]);
   const downloads = useSelector(getPluginDownloadStatusMap);
   const downloadStatus = useMemo(

desktop/flipper-ui-core/src/chrome/plugin-manager/PluginDebugger.tsx

@@ -140,7 +140,7 @@ class PluginDebugger extends Component<Props> {
   getRows(): Array<TableBodyRow> {
     const rows: Array<TableBodyRow> = [];
 
-    const externalPluginPath = (p: any) => (p.isBundled ? 'bundled' : p.entry);
+    const externalPluginPath = (p: any) => p.entry;
 
     this.props.gatekeepedPlugins.forEach((plugin) =>
       rows.push(

desktop/flipper-ui-core/src/chrome/plugin-manager/__tests__/PluginInstaller.node.tsx

@@ -43,7 +43,6 @@ const samplePluginDetails1: UpdatablePluginDetails = {
   id: 'Hello',
   title: 'Hello',
   description: 'World?',
-  isBundled: false,
   isActivatable: true,
   updateStatus: {
     kind: 'not-installed',
@@ -63,7 +62,6 @@ const samplePluginDetails2: UpdatablePluginDetails = {
   id: 'World',
   title: 'World',
   description: 'Hello?',
-  isBundled: false,
   isActivatable: true,
   updateStatus: {
     kind: 'not-installed',