Remove plugin bundling

Summary: Remove the notion of bundled plugins

Reviewed By: lblasa

Differential Revision: D39308888

fbshipit-source-id: aa88ddbf2801ad1da95f89e4c761259b697b0d66

desktop/flipper-plugin-core/src/plugin/PluginBase.tsx

@@ -547,9 +547,7 @@ export abstract class BasePluginInstance {
       this.serverAddOnControls
         .start(
           pluginDetails.name,
-          pluginDetails.isBundled
-            ? {isBundled: true}
-            : {path: pluginDetails.serverAddOnEntry!},
+          {path: pluginDetails.serverAddOnEntry!},
           this.serverAddOnOwner,
         )
         .then(() => {

desktop/flipper-plugin-core/src/plugin/SandyPluginDefinition.tsx

@@ -128,10 +128,6 @@ export class SandyPluginDefinition {
     return this.details.version;
   }
 
-  get isBundled() {
-    return this.details.isBundled;
-  }
-
   get keyboardActions() {
     // TODO: T68882551 support keyboard actions
     return [];

desktop/flipper-plugin-core/src/test-utils/test-utils.tsx

@@ -7,11 +7,7 @@
  * @format
  */
 
-import {
-  BundledPluginDetails,
-  fsConstants,
-  InstalledPluginDetails,
-} from 'flipper-common';
+import {fsConstants, InstalledPluginDetails} from 'flipper-common';
 
 import {FlipperServer, FlipperServerCommands} from 'flipper-common';
 import {Device} from '../plugin/DevicePlugin';
@@ -115,7 +111,6 @@ export function createMockPluginDetails(
     name: 'TestPlugin',
     specVersion: 0,
     entry: '',
-    isBundled: false,
     isActivatable: true,
     main: '',
     source: '',
@@ -166,24 +161,6 @@ export function createTestDevicePlugin(
   );
 }
 
-export function createMockBundledPluginDetails(
-  details?: Partial<BundledPluginDetails>,
-): BundledPluginDetails {
-  return {
-    id: 'TestBundledPlugin',
-    name: 'TestBundledPlugin',
-    specVersion: 0,
-    pluginType: 'client',
-    isBundled: true,
-    isActivatable: true,
-    main: '',
-    source: '',
-    title: 'Testing Bundled Plugin',
-    version: '',
-    ...details,
-  };
-}
-
 export function createFlipperServerMock(
   overrides?: Partial<FlipperServerCommands>,
 ): FlipperServer {