jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Broken sample app (#103)

Browse Source 
Summary:
With this fix the entire android setup builds with gradle ✨. To try out the sample app, run `./gradlew :sample:installDebug`
Closes https://github.com/facebook/Sonar/pull/103

Reviewed By: danielbuechele

Differential Revision: D8618622

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 62a038f95c37cbadf48636a58ca222c8162e256e
This commit is contained in:
Pritesh Nandgaonkar
2018-06-25 11:26:25 -07:00
committed by Facebook Github Bot
parent cbab597236
commit 64a61a37d4
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
android/sample/build.gradle
View File

@@ -61,5 +61,4 @@ dependencies {
implementation deps.okhttp3 implementation deps.okhttp3
implementation project(':android') implementation project(':android')
implementation project(':fbjni')
} }

5
libs/fbjni/cxx/fbjni/detail/References.cpp
View File

@@ -54,7 +54,10 @@ bool doesGetObjectRefTypeWork() {
} }
bool isObjectRefType(jobject reference, jobjectRefType refType) { bool isObjectRefType(jobject reference, jobjectRefType refType) {
static bool getObjectRefTypeWorks = doesGetObjectRefTypeWork();
// TODO Rather than setting it true, use doesGetObjectRefTypeWork(). But it
// causes sample app to freeze
static bool getObjectRefTypeWorks = true;
return return
!reference || !reference ||