jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Back out "Merge internal and external troubleshooting pages into one with optional internal-only content"

Browse Source 
Summary: Unfortunately optional require does not work with docusaurus bundler configuration in case file not exist, so open source build is failing now. I'm backing out this commit until solution for dynamic imports in docusaurus found.

Reviewed By: mweststrate

Differential Revision: D23679147

fbshipit-source-id: 7934e0a7decf128c1914f52645adaf4617c97eea
This commit is contained in:
Anton Nikolaev
2020-09-14 07:32:58 -07:00
committed by Facebook GitHub Bot
parent 8425db7b8b
commit 643a656cd9
4 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/getting-started/index.mdx
View File

@@ -2,6 +2,7 @@
id: index id: index
title: Desktop App title: Desktop App
--- ---
import useBaseUrl from '@docusaurus/useBaseUrl';
import FBContent from '../../website/src/components/FBContent'; import FBContent from '../../website/src/components/FBContent';
Flipper helps you debug Android and iOS apps running in an emulator/simulator or connected physical development devices. Flipper consists of two parts: Flipper helps you debug Android and iOS apps running in an emulator/simulator or connected physical development devices. Flipper consists of two parts:

7
docs/troubleshooting.mdx
View File

@@ -5,7 +5,6 @@ sidebar_label: Troubleshooting Issues
--- ---
import useBaseUrl from '@docusaurus/useBaseUrl'; import useBaseUrl from '@docusaurus/useBaseUrl';
import Link from '@docusaurus/Link'; import Link from '@docusaurus/Link';
import FBContent from '../website/src/components/FBContent';
We hope that flipper works well out of the box, but the software is a work in progress and problems will occur. Below are some known issues and steps you can take to try to resolve them. We hope that flipper works well out of the box, but the software is a work in progress and problems will occur. Below are some known issues and steps you can take to try to resolve them.
@@ -166,9 +165,3 @@ If you experience errors such as `Undefined symbol: associated type descriptor f
<img alt="Screenshot showing the places mentioned in the last steps" src={useBaseUrl("img/troubleshooting-react-native-ios-swift-2.png")} /> <img alt="Screenshot showing the places mentioned in the last steps" src={useBaseUrl("img/troubleshooting-react-native-ios-swift-2.png")} />
1. Now you can run your build normally. 1. Now you can run your build normally.
## Facebook-specific issues
<FBContent
internal={() => require('./fb/troubleshooting.mdx')}
external={"Luckily you're in Open Source, so you don't have to worry about this stuff."} />

3
website/sidebars.js
View File

@@ -97,7 +97,8 @@ module.exports = {
], ],
}, },
'fb-internal': { 'fb-internal': {
'FB Internal': fbInternalOnly([ 'FB Internal': fbInternalOnly([
'fb/troubleshooting',
'fb/Add-flipper-to-android-app', 'fb/Add-flipper-to-android-app',
'fb/Adding-flipper-to-ios-app', 'fb/Adding-flipper-to-ios-app',
'fb/LauncherConfig', 'fb/LauncherConfig',

3
website/src/components/FBContent.jsx
View File

@@ -17,9 +17,6 @@ function createElement(createElement) {
if (React.isValidElement(createElement)) { if (React.isValidElement(createElement)) {
return createElement; return createElement;
} }
if (typeof createElement === 'string') {
return createElement;
}
const element = createElement(); const element = createElement();
if (React.isValidElement(element)) { if (React.isValidElement(element)) {
return element; return element;