jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleanup and some code reuse between Device- and normal Plugins

Browse Source 
Summary: Introducing a base abstract class (blegh) to share some life cycle management between Device- and normal plugins. Cleaned up the test utils a bit as well + some old TODO's that now have been taken care of

Reviewed By: nikoant

Differential Revision: D22727089

fbshipit-source-id: 507816f1bfdbc6e7e71d4bd365b881b6710ca917
This commit is contained in:
Michel Weststrate
2020-08-04 07:05:57 -07:00
committed by Facebook GitHub Bot
parent b9c9e89b53
commit 642261c0d0
13 changed files with 275 additions and 353 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/app/src/utils/exportData.tsx
View File

@@ -662,7 +662,7 @@ async function getStoreExport(
const newPluginState = metadata.pluginStates;
// TODO: support async export like fetchMetaData T68683476
// TODO: support device plugins T68738317
// TODO: support device plugins T70582933
const pluginStates2 = pluginsToProcess
? exportSandyPluginStates(pluginsToProcess)
: {};

1
desktop/app/src/utils/messageQueue.tsx
View File

@@ -128,7 +128,6 @@ export function processMessagesLater(
case isSelected && getPendingMessages(store, pluginKey).length === 0:
processMessagesImmediately(store, pluginKey, plugin, messages);
break;
// TODO: support SandyDevicePlugin T68738317
case isSelected:
case plugin instanceof SandyPluginInstance:
case plugin instanceof FlipperDevicePlugin: