From 6362188563b5ecc72841ef876cadc48c2d0e4b03 Mon Sep 17 00:00:00 2001 From: Panagiotis Vekris Date: Wed, 14 Nov 2018 13:25:58 -0800 Subject: [PATCH] Flow v0.86.0 in xplat/sonar Summary: allow-large-files Reviewed By: zertosh Differential Revision: D13067587 fbshipit-source-id: f0122c8c6d602750289121d2ab2fdb09cbb033bc --- .flowconfig | 2 +- package.json | 2 +- src/App.js | 4 ++++ src/NotificationsHub.js | 4 ++++ src/PluginContainer.js | 4 ++++ src/chrome/DetailSidebar.js | 4 ++++ src/chrome/DevicesButton.js | 4 ++++ src/chrome/MainSidebar.js | 4 ++++ src/chrome/ScreenCaptureButtons.js | 4 ++++ src/chrome/TitleBar.js | 4 ++++ src/plugins/logs/LogWatcher.js | 4 ++++ src/reducers/index.js | 4 ++++ src/ui/components/elements-inspector/sidebar.js | 4 ++++ yarn.lock | 8 ++++---- 14 files changed, 50 insertions(+), 6 deletions(-) diff --git a/.flowconfig b/.flowconfig index 2bce30b60..7c4634d45 100644 --- a/.flowconfig +++ b/.flowconfig @@ -23,4 +23,4 @@ module.name_mapper='flipper' -> '/src/index.js' suppress_type=$FlowFixMe [version] -^0.84.0 +^0.86.0 diff --git a/package.json b/package.json index 929a8ef05..d4fe472a8 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "eslint-plugin-prettier": "^2.4.0", "eslint-plugin-react": "^7.5.1", "eslint-plugin-relay": "^0.0.20", - "flow-bin": "^0.84.0", + "flow-bin": "^0.86.0", "glob": "^7.1.2", "jest": "^23.6.0", "prettier": "1.13.6", diff --git a/src/App.js b/src/App.js index da3d2384c..6b8d15dae 100644 --- a/src/App.js +++ b/src/App.js @@ -72,6 +72,10 @@ export class App extends React.Component { ); } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default connect( ({ application: {pluginManagerVisible, bugDialogVisible, leftSidebarVisible}, diff --git a/src/NotificationsHub.js b/src/NotificationsHub.js index d437ea1ab..b921201e2 100644 --- a/src/NotificationsHub.js +++ b/src/NotificationsHub.js @@ -311,6 +311,10 @@ class NotificationsTable extends Component { } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ const ConnectedNotificationsTable = connect( ({ notifications: { diff --git a/src/PluginContainer.js b/src/PluginContainer.js index 0fe5307d1..d8fa1899e 100644 --- a/src/PluginContainer.js +++ b/src/PluginContainer.js @@ -168,6 +168,10 @@ class PluginContainer extends Component { } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default connect( ({ application: {rightSidebarVisible, rightSidebarAvailable}, diff --git a/src/chrome/DetailSidebar.js b/src/chrome/DetailSidebar.js index 0d3d5e477..6e9068df8 100644 --- a/src/chrome/DetailSidebar.js +++ b/src/chrome/DetailSidebar.js @@ -51,6 +51,10 @@ class DetailSidebar extends React.Component { } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default connect( ({application: {rightSidebarVisible, rightSidebarAvailable}}) => ({ rightSidebarVisible, diff --git a/src/chrome/DevicesButton.js b/src/chrome/DevicesButton.js index 79e3c9bfb..ce3568a93 100644 --- a/src/chrome/DevicesButton.js +++ b/src/chrome/DevicesButton.js @@ -94,6 +94,10 @@ class DevicesButton extends Component { ); } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default connect( ({connections: {devices, androidEmulators, selectedDevice}}) => ({ devices, diff --git a/src/chrome/MainSidebar.js b/src/chrome/MainSidebar.js index df68e7867..a79b36ce1 100644 --- a/src/chrome/MainSidebar.js +++ b/src/chrome/MainSidebar.js @@ -281,6 +281,10 @@ class MainSidebar extends Component { } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default connect( ({ application: {windowIsFocused}, diff --git a/src/chrome/ScreenCaptureButtons.js b/src/chrome/ScreenCaptureButtons.js index a70276806..9ff9ad732 100644 --- a/src/chrome/ScreenCaptureButtons.js +++ b/src/chrome/ScreenCaptureButtons.js @@ -282,6 +282,10 @@ class ScreenCaptureButtons extends Component { } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default connect(({connections: {selectedDevice}}) => ({ selectedDevice, }))(ScreenCaptureButtons); diff --git a/src/chrome/TitleBar.js b/src/chrome/TitleBar.js index d8392feba..33caba286 100644 --- a/src/chrome/TitleBar.js +++ b/src/chrome/TitleBar.js @@ -107,6 +107,10 @@ class TitleBar extends Component { } } +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default connect( ({ application: { diff --git a/src/plugins/logs/LogWatcher.js b/src/plugins/logs/LogWatcher.js index 63f8ccf0d..9a7286713 100644 --- a/src/plugins/logs/LogWatcher.js +++ b/src/plugins/logs/LogWatcher.js @@ -130,6 +130,10 @@ export default class LogWatcher extends PureComponent { }; buildRows = () => { + /* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ return this.props.counters.map(({label, count, notify}, i) => ({ columns: { expression: { diff --git a/src/reducers/index.js b/src/reducers/index.js index a77dff7a1..baf329bb7 100644 --- a/src/reducers/index.js +++ b/src/reducers/index.js @@ -45,6 +45,10 @@ export type Store = ReduxStore< | {|type: 'INIT'|}, >; +/* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ export default combineReducers({ application, connections: persistReducer( diff --git a/src/ui/components/elements-inspector/sidebar.js b/src/ui/components/elements-inspector/sidebar.js index 55c4ea757..9535e8743 100644 --- a/src/ui/components/elements-inspector/sidebar.js +++ b/src/ui/components/elements-inspector/sidebar.js @@ -120,6 +120,10 @@ export class InspectorSidebar extends Component { const sections = (extensions && + /* $FlowFixMe(>=0.86.0) This + * comment suppresses an error found when Flow v0.86 was + * deployed. To see the error, delete this comment and + * run Flow. */ extensions.map(ext => ext( this.props.client, diff --git a/yarn.lock b/yarn.lock index 886040492..9826ce5ba 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2804,10 +2804,10 @@ flat-cache@^1.2.1: graceful-fs "^4.1.2" write "^0.2.1" -flow-bin@^0.84.0: - version "0.84.0" - resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.84.0.tgz#4cb2364c750fb37a7840524fa62456b53f64cdcb" - integrity sha512-ocji8eEYp+YfICsm+F6cIHUcD7v5sb0/ADEXm6gyUKdjQzmSckMrPUdZtyfP973t3YGHKliUMxMvIBHyR5LbXQ== +flow-bin@^0.86.0: + version "0.86.0" + resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.86.0.tgz#153a28722b4dc13b7200c74b644dd4d9f4969a11" + integrity sha512-ulRvFH3ewGIYwg+qPk/OJXoe3Nhqi0RyR0wqgK0b1NzUDEC6O99zU39MBTickXvlrr6iwRO6Wm4lVGeDmnzbew== flow-parser@^0.*: version "0.81.0"