From 6359c82be195c7796c68019e0ec9a398fc3f85ef Mon Sep 17 00:00:00 2001 From: Mathias Fleig Mortensen Date: Wed, 15 Sep 2021 07:46:09 -0700 Subject: [PATCH] Add memory consumption treemap tab Summary: There are some issues with label positioning, but overall works. Reviewed By: defHLT Differential Revision: D29588329 fbshipit-source-id: 5c2e8f6f139d997559111fa2ad124ae1d695b36a --- desktop/plugins/public/fresco/ImagePool.tsx | 4 +- .../public/fresco/ImagesCacheOverview.tsx | 21 +- .../public/fresco/ImagesMemoryOverview.tsx | 142 +++++++++ desktop/plugins/public/fresco/api.tsx | 2 + desktop/plugins/public/fresco/index.tsx | 67 +++-- desktop/plugins/public/fresco/package.json | 3 + desktop/plugins/public/yarn.lock | 278 +++++++++++++++++- 7 files changed, 476 insertions(+), 41 deletions(-) create mode 100644 desktop/plugins/public/fresco/ImagesMemoryOverview.tsx diff --git a/desktop/plugins/public/fresco/ImagePool.tsx b/desktop/plugins/public/fresco/ImagePool.tsx index 027265d72..d595e6b04 100644 --- a/desktop/plugins/public/fresco/ImagePool.tsx +++ b/desktop/plugins/public/fresco/ImagePool.tsx @@ -7,9 +7,7 @@ * @format */ -import {ImageId, ImageData} from './api'; - -export type ImagesMap = {[imageId in ImageId]: ImageData}; +import {ImageId, ImageData, ImagesMap} from './api'; const maxInflightRequests = 10; diff --git a/desktop/plugins/public/fresco/ImagesCacheOverview.tsx b/desktop/plugins/public/fresco/ImagesCacheOverview.tsx index 4be7f49de..eb87ec884 100644 --- a/desktop/plugins/public/fresco/ImagesCacheOverview.tsx +++ b/desktop/plugins/public/fresco/ImagesCacheOverview.tsx @@ -7,7 +7,7 @@ * @format */ -import {CacheInfo, ImageId, ImageData, ImagesList} from './api'; +import {CacheInfo, ImageId, ImageData, ImagesList, ImagesMap} from './api'; import {ImageEventWithId} from './index'; import {styled, Layout, Toolbar, theme} from 'flipper-plugin'; @@ -23,15 +23,22 @@ import { Badge, } from 'antd'; import MultipleSelect from './MultipleSelect'; -import {ImagesMap} from './ImagePool'; import React, {PureComponent} from 'react'; import {DeleteFilled} from '@ant-design/icons'; -function formatMB(bytes: number) { - return Math.floor(bytes / (1024 * 1024)) + 'MB'; +function toMB(bytes: number) { + return Math.floor(bytes / (1024 * 1024)); } -function formatKB(bytes: number) { +export function toKB(bytes: number) { + return Math.floor(bytes / 1024); +} + +export function formatMB(bytes: number) { + return toMB(bytes) + 'MB'; +} + +export function formatKB(bytes: number) { return Math.floor(bytes / 1024) + 'KB'; } @@ -148,7 +155,7 @@ export default class ImagesCacheOverview extends PureComponent< ) > 0; return ( - +