From 62e9181075f614123adfb060ddb4fe3510de2f3c Mon Sep 17 00:00:00 2001 From: Luke De Feo Date: Thu, 2 Nov 2023 12:29:07 -0700 Subject: [PATCH] Improve logging Summary: Lets make the logging higher signal Reviewed By: passy Differential Revision: D50853449 fbshipit-source-id: 95ebfbc142c34c36fb11e459c573842580cd6e4c --- .../flipper/plugins/uidebugger/core/DecorViewTracker.kt | 7 ++++--- .../flipper/plugins/uidebugger/core/UpdateQueue.kt | 2 -- .../flipper/plugins/uidebugger/util/EnumMapping.kt | 5 ----- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/DecorViewTracker.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/DecorViewTracker.kt index 83aef111f..64a7fab24 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/DecorViewTracker.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/DecorViewTracker.kt @@ -43,7 +43,6 @@ class DecorViewTracker(private val context: UIDContext, private val snapshotter: private val mStopWatch = StopWatch() fun start() { - Log.i(LogTag, "Subscribing activity / root view changes") val applicationRef = context.applicationRef @@ -55,6 +54,7 @@ class DecorViewTracker(private val context: UIDContext, private val snapshotter: override fun onRootViewsChanged(rootViews: List) { // remove predraw listen from current view as its going away or will be covered + Log.i(LogTag, "Removing pre draw listener from ${currentDecorView?.objectIdentity()}") currentDecorView?.viewTreeObserver?.removeOnPreDrawListener(preDrawListener) // setup new listener on top most view, that will be the active child in traversal @@ -85,8 +85,9 @@ class DecorViewTracker(private val context: UIDContext, private val snapshotter: // On subscribe, trigger a traversal on whatever roots we have rootViewListener.onRootViewsChanged(applicationRef.rootsResolver.rootViews()) - Log.i(LogTag, "${context.applicationRef.rootsResolver.rootViews().size} root views") - Log.i(LogTag, "${context.applicationRef.activitiesStack.size} activities") + Log.i( + LogTag, + "Starting tracking root views, currently ${context.applicationRef.rootsResolver.rootViews().size} root views") } fun stop() { diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/UpdateQueue.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/UpdateQueue.kt index fd785728c..23b6b59cb 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/UpdateQueue.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/core/UpdateQueue.kt @@ -131,8 +131,6 @@ class UpdateQueue(val context: UIDContext) { val (_, sendTimeMs) = StopWatch.time { context.connectionRef.connection?.send(FrameScanEvent.name, serialized) } - Log.i(LogTag, "Sent frame with nodes ${nodes.size}") - // Note about payload size: // Payload size is an approximation as it assumes all characters // are ASCII encodable, this should be true for most of the payload content. diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/util/EnumMapping.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/util/EnumMapping.kt index bd0f41edc..71f5a786f 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/util/EnumMapping.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/util/EnumMapping.kt @@ -7,8 +7,6 @@ package com.facebook.flipper.plugins.uidebugger.util -import android.util.Log -import com.facebook.flipper.plugins.uidebugger.LogTag import com.facebook.flipper.plugins.uidebugger.model.InspectableValue // Maintains 2 way mapping between some enum value and a readable string representation @@ -19,9 +17,6 @@ open class EnumMapping(private val mapping: Map) { return if (entry != null) { entry.key } else { - Log.v( - LogTag, - "Could not convert enum value ${enumValue.toString()} to string, known values ${mapping.entries}") NoMapping } }