diff --git a/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx b/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx index 1c0b753bd..65766907c 100644 --- a/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx +++ b/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx @@ -91,7 +91,7 @@ export function ConsoleLogs() { return ( - + diff --git a/desktop/flipper-ui-core/src/reducers/application.tsx b/desktop/flipper-ui-core/src/reducers/application.tsx index 33cd8159a..a0432b6f8 100644 --- a/desktop/flipper-ui-core/src/reducers/application.tsx +++ b/desktop/flipper-ui-core/src/reducers/application.tsx @@ -13,7 +13,6 @@ import {Actions} from './'; export type ToplevelNavigationItem = | 'appinspect' - | 'flipperlogs' | 'notification' | 'connectivity' | undefined; diff --git a/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx b/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx index 34a8e43ce..697098420 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx @@ -470,6 +470,8 @@ function TroubleshootMenu() { const [status, setStatus] = useState< ExportEverythingEverywhereAllAtOnceStatus | undefined >(); + const [isFlipperDevToolsModalOpen, setFlipperDevToolsModalOpen] = + useState(false); const exportEverythingEverywhereAllAtOnceTracked = useTrackedCallback( 'Debug data export', @@ -530,8 +532,7 @@ function TroubleshootMenu() { { - store.dispatch(setTopLevelSelection('flipperlogs')); - store.dispatch(setStaticView(FlipperDevTools)); + setFlipperDevToolsModalOpen(true); }}> Flipper Logs @@ -548,10 +549,38 @@ function TroubleshootMenu() { status={status} setStatus={setStatus} /> + setFlipperDevToolsModalOpen(false)} + /> ); } +function FlipperDevToolsModal({ + isOpen, + onClose, +}: { + isOpen: boolean; + onClose: () => void; +}) { + return ( + +
+ +
+
+ ); +} + function ExtrasMenu() { const store = useStore();