jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make rootNode a weak reference in SKComponentLayoutWrapper

Browse Source 
Summary: In some cases this can cause a retain cycle.

Reviewed By: priteshrnandgaonkar

Differential Revision: D18297780

fbshipit-source-id: c60abdcaad9fd94c457647509aec0519042801e4
This commit is contained in:
Kevin Lin
2019-11-05 09:56:47 -08:00
committed by Facebook Github Bot
parent 3cee927674
commit 5ca8b6dc30
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutWrapper.h
View File

@@ -19,7 +19,7 @@
@property (nonatomic, readonly) CGSize size; @property (nonatomic, readonly) CGSize size;
@property (nonatomic, readonly) CGPoint position; @property (nonatomic, readonly) CGPoint position;
@property (nonatomic, readonly) std::vector<SKComponentLayoutWrapper *> children; @property (nonatomic, readonly) std::vector<SKComponentLayoutWrapper *> children;
@property (nonatomic, readonly) id<CKInspectableView> rootNode; @property (nonatomic, weak, readonly) id<CKInspectableView> rootNode;
// Null for layouts which are not direct children of a CKFlexboxComponent // Null for layouts which are not direct children of a CKFlexboxComponent
@property (nonatomic, readonly) BOOL isFlexboxChild; @property (nonatomic, readonly) BOOL isFlexboxChild;
@property (nonatomic, readonly) CKFlexboxComponentChild flexboxChild; @property (nonatomic, readonly) CKFlexboxComponentChild flexboxChild;