From 5c81aefe9a07c9f06e0e34c6c64e8d3b2fad9b00 Mon Sep 17 00:00:00 2001
From: John Knox <jknox@fb.com>
Date: Fri, 3 Aug 2018 08:50:24 -0700
Subject: [PATCH] Use unlinkSync instead of unlink

Summary:
fs.unlink() requires a callback and we weren't passing one.
Using synchronous version instead.

Reviewed By: passy

Differential Revision: D9148214

fbshipit-source-id: 8a3c1103d93fced5e3c25c38775badb72c23e48a
---
 src/utils/CertificateProvider.js | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/src/utils/CertificateProvider.js b/src/utils/CertificateProvider.js
index d2327b04c..1f71bac9a 100644
--- a/src/utils/CertificateProvider.js
+++ b/src/utils/CertificateProvider.js
@@ -136,8 +136,15 @@ export default class CertificateProvider {
       CAkey: caKey,
       CAcreateserial: true,
     }).then(cert => {
-      fs.unlinkSync(csrFile);
-      return cert;
+      return new Promise(function(resolve, reject) {
+        fs.unlink(csrFile, err => {
+          if (err) {
+            reject(err);
+          } else {
+            resolve(cert);
+          }
+        });
+      });
     });
   }
 
@@ -308,8 +315,15 @@ export default class CertificateProvider {
       RFC2253: false,
     })
       .then(subject => {
-        fs.unlink(csrFile);
-        return subject;
+        return new Promise(function(resolve, reject) {
+          fs.unlink(csrFile, err => {
+            if (err) {
+              reject(err);
+            } else {
+              resolve(subject);
+            }
+          });
+        });
       })
       .then(subject => {
         const matches = subject.trim().match(x509SubjectCNRegex);