jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use component.className instead of NSStringFromClass

Browse Source 
Summary: Use `component.className` in sonar for the layout inspector.

Reviewed By: kfirapps

Differential Revision: D20184486

fbshipit-source-id: 3e7564b2561016ee59f3b1fc9d21313e068bacb3
This commit is contained in:
Hugo Cuvillier
2020-03-06 04:02:57 -08:00
committed by Facebook Github Bot
parent 31c9df92b8
commit 5a4ac4c32d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/CKComponent+Sonar.mm
View File

@@ -109,10 +109,10 @@ static CK::StaticMutex _mutex = CK_MUTEX_INITIALIZER;
auto const canBeReusedCounter = self.flipper_canBeReusedCounter; auto const canBeReusedCounter = self.flipper_canBeReusedCounter;
if (canBeReusedCounter > 0) { if (canBeReusedCounter > 0) {
return [NSString stringWithFormat:@"%@ (Can be reused x%lu)", return [NSString stringWithFormat:@"%@ (Can be reused x%lu)",
NSStringFromClass([self class]), self.className,
(unsigned long)canBeReusedCounter]; (unsigned long)canBeReusedCounter];
} }
return NSStringFromClass([self class]); return self.className;
} }
- (NSString*)sonar_getDecoration { - (NSString*)sonar_getDecoration {

2
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutWrapper.mm
View File

@@ -98,7 +98,7 @@ static CKFlexboxComponentChild findFlexboxLayoutParams(
_size = layout.size; _size = layout.size;
_position = position; _position = position;
_identifier = [parentKey stringByAppendingString:layout.component _identifier = [parentKey stringByAppendingString:layout.component
? NSStringFromClass([layout.component class]) ? layout.component.className
: @"(null)"]; : @"(null)"];
if (_component && reuseWrapper) { if (_component && reuseWrapper) {