Allow plugins to use css
Summary: Flipper plugins fail when importing css from third-party dependencies. This diff tries to fix that. Effectively, the plugin can import the css and export it when is bundled. When we load the plugin, we check if there's a css file for it. If there's one, we return it and try to use it. Reviewed By: aigoncharov Differential Revision: D40758178 fbshipit-source-id: e53afffcc481504905d5eeb1aea1f9114ee2a86b
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ff282630be
commit
587f428cf8
@@ -28,9 +28,18 @@ export const SandyPluginRenderer = memo(({plugin}: Props) => {
|
||||
throw new Error('Expected plugin, got ' + plugin);
|
||||
}
|
||||
useEffect(() => {
|
||||
const style = document.createElement('style');
|
||||
if (plugin.definition.css) {
|
||||
style.innerText = plugin.definition.css;
|
||||
document.head.appendChild(style);
|
||||
}
|
||||
|
||||
plugin.activate();
|
||||
return () => {
|
||||
plugin.deactivate();
|
||||
if (plugin.definition.css) {
|
||||
document.head.removeChild(style);
|
||||
}
|
||||
};
|
||||
}, [plugin]);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user