Allow plugins to use css
Summary: Flipper plugins fail when importing css from third-party dependencies. This diff tries to fix that. Effectively, the plugin can import the css and export it when is bundled. When we load the plugin, we check if there's a css file for it. If there's one, we return it and try to use it. Reviewed By: aigoncharov Differential Revision: D40758178 fbshipit-source-id: e53afffcc481504905d5eeb1aea1f9114ee2a86b
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ff282630be
commit
587f428cf8
@@ -189,8 +189,24 @@ export async function initializeElectron(
|
||||
return flipperServerConfig.gatekeepers[gatekeeper] ?? false;
|
||||
},
|
||||
flipperServer,
|
||||
async requirePlugin(path) {
|
||||
return electronRequire(path);
|
||||
async requirePlugin(path): Promise<{plugin: any; css?: string}> {
|
||||
const plugin = electronRequire(path);
|
||||
/**
|
||||
* Check if the plugin includes a bundled css. If so,
|
||||
* load its content too.
|
||||
*/
|
||||
const idx = path.lastIndexOf('.');
|
||||
const cssPath = path.substring(0, idx < 0 ? path.length : idx) + '.css';
|
||||
try {
|
||||
await fs.promises.access(cssPath);
|
||||
|
||||
const buffer = await fs.promises.readFile(cssPath, {encoding: 'utf-8'});
|
||||
const css = buffer.toString();
|
||||
|
||||
return {plugin, css};
|
||||
} catch (e) {}
|
||||
|
||||
return {plugin};
|
||||
},
|
||||
getStaticResourceUrl(relativePath): string {
|
||||
return (
|
||||
|
||||
Reference in New Issue
Block a user