From 583fdd9648c937d63eec60eee2ebfbc4827e14a8 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Fri, 1 Jul 2022 03:45:44 -0700 Subject: [PATCH] Explicitly close ws in cases of a process exit Summary: ^ There may be cases whereas the process exits but leaks the socket descriptors. There's already a hook to close flipper-server. Reviewed By: passy Differential Revision: D37550940 fbshipit-source-id: 35004969834bb92bb7cf0f56bda8d7b43c11d6bf --- desktop/flipper-server/src/index.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/desktop/flipper-server/src/index.tsx b/desktop/flipper-server/src/index.tsx index 36b911a14..47664a2c4 100644 --- a/desktop/flipper-server/src/index.tsx +++ b/desktop/flipper-server/src/index.tsx @@ -18,6 +18,7 @@ import open from 'open'; import {initCompanionEnv} from 'flipper-server-companion'; import {startFlipperServer, startServer} from 'flipper-server-core'; import {isTest} from 'flipper-common'; +import exitHook from 'exit-hook'; const argv = yargs .usage('yarn flipper-server [args]') @@ -115,6 +116,10 @@ async function start() { 'external', ); + exitHook(async () => { + await flipperServer.close(); + }); + enhanceLogger((logEntry) => { flipperServer.emit('server-log', logEntry); });