From 56576a84ce81fa13849612c45bd741de1abe1efc Mon Sep 17 00:00:00 2001 From: John Knox Date: Wed, 27 Feb 2019 10:40:41 -0800 Subject: [PATCH] Fix app crash when payload is too large Summary: Fixes T40544233 Exceptions should be thrown by value, not as a pointer, or else catching by reference (the recommended practice) won't work. Reviewed By: priteshrnandgaonkar Differential Revision: D14243337 fbshipit-source-id: 28677d7f1b3c025b67fb945f30116f3b751a89a8 --- xplat/Flipper/FlipperConnectionManagerImpl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xplat/Flipper/FlipperConnectionManagerImpl.cpp b/xplat/Flipper/FlipperConnectionManagerImpl.cpp index 3d924f947..af0ddbbad 100644 --- a/xplat/Flipper/FlipperConnectionManagerImpl.cpp +++ b/xplat/Flipper/FlipperConnectionManagerImpl.cpp @@ -357,7 +357,7 @@ rsocket::Payload toRSocketPayload(dynamic data) { json.substr(0, 100) + "..."; log(logMessage); DCHECK_LE(payloadLength, maxPayloadSize); - throw new std::length_error(logMessage); + throw std::length_error(logMessage); } return payload;