jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Augument IDB installation instructions for intern users

Browse Source 
Reviewed By: passy

Differential Revision: D37994214

fbshipit-source-id: bd36abf1ed024ca1f18fcc5297108e4ca333c578
This commit is contained in:
Andrey Goncharov
2022-07-20 06:03:38 -07:00
committed by Facebook GitHub Bot
parent f3cb9de5c9
commit 55b7ef934c
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
desktop/doctor/src/fb-stubs/idbInstallationInstructions.tsx Normal file
View File

@@ -0,0 +1,11 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
*/
export const getIdbInstallationInstructions = (idbPath: string) =>
`IDB is required to use Flipper with iOS devices. It can be installed from https://github.com/facebook/idb and configured in Flipper settings. You can also disable physical iOS device support in settings. Current setting: ${idbPath} isn't a valid IDB installation.`;

3
desktop/doctor/src/index.tsx
View File

@@ -17,6 +17,7 @@ import * as fs from 'fs';
import * as path from 'path';
import type {FlipperDoctor} from 'flipper-common';
import * as fs_extra from 'fs-extra';
import {getIdbInstallationInstructions} from './fb-stubs/idbInstallationInstructions';
export function getHealthchecks(): FlipperDoctor.Healthchecks {
return {
@@ -246,7 +247,7 @@ export function getHealthchecks(): FlipperDoctor.Healthchecks {
);
const hasProblem = result.hasProblem;
const message = hasProblem
? `IDB is required to use Flipper with iOS devices. It can be installed from https://github.com/facebook/idb and configured in Flipper settings. You can also disable physical iOS device support in settings. Current setting: ${settings.idbPath} isn't a valid IDB installation.`
? getIdbInstallationInstructions(settings.idbPath)
: 'Flipper is configured to use your IDB installation.';
return {
hasProblem,