Make sure icons are bundled
Summary: Make sure icons are prefetched for flipper-server prod builds, like we do for electron, so that the user doesn't need an internet connection to see icons Reviewed By: nikoant Differential Revision: D33296389 fbshipit-source-id: bfa92d78d8d77030238e5cca10d7aa6dcfb88e8b
This commit is contained in:
committed by
Facebook GitHub Bot
parent
72fa481d27
commit
54dacb7e5d
96
desktop/scripts/build-icons.ts
Normal file
96
desktop/scripts/build-icons.ts
Normal file
@@ -0,0 +1,96 @@
|
||||
/**
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @format
|
||||
*/
|
||||
|
||||
import path from 'path';
|
||||
import fs from 'fs-extra';
|
||||
import fetch from '@adobe/node-fetch-retry';
|
||||
// eslint-disable-next-line node/no-extraneous-import
|
||||
import type {Icon} from 'flipper-ui-core';
|
||||
|
||||
export type Icons = {
|
||||
[key: string]: Icon['size'][];
|
||||
};
|
||||
|
||||
// Takes a string like 'star', or 'star-outline', and converts it to
|
||||
// {trimmedName: 'star', variant: 'filled'} or {trimmedName: 'star', variant: 'outline'}
|
||||
function getIconPartsFromName(icon: string): {
|
||||
trimmedName: string;
|
||||
variant: 'outline' | 'filled';
|
||||
} {
|
||||
const isOutlineVersion = icon.endsWith('-outline');
|
||||
const trimmedName = isOutlineVersion ? icon.replace('-outline', '') : icon;
|
||||
const variant = isOutlineVersion ? 'outline' : 'filled';
|
||||
return {trimmedName: trimmedName, variant: variant};
|
||||
}
|
||||
|
||||
export async function downloadIcons(buildFolder: string) {
|
||||
const icons: Icons = JSON.parse(
|
||||
await fs.promises.readFile(path.join(buildFolder, 'icons.json'), {
|
||||
encoding: 'utf8',
|
||||
}),
|
||||
);
|
||||
const iconURLs = Object.entries(icons).reduce<Icon[]>(
|
||||
(acc, [entryName, sizes]) => {
|
||||
const {trimmedName: name, variant} = getIconPartsFromName(entryName);
|
||||
acc.push(
|
||||
// get icons in @1x and @2x
|
||||
...sizes.map((size) => ({name, variant, size, density: 1})),
|
||||
...sizes.map((size) => ({name, variant, size, density: 2})),
|
||||
);
|
||||
return acc;
|
||||
},
|
||||
[],
|
||||
);
|
||||
|
||||
return Promise.all(
|
||||
iconURLs.map((icon) => {
|
||||
const url = getPublicIconUrl(icon);
|
||||
return fetch(url, {
|
||||
retryOptions: {
|
||||
// Be default, only 5xx are retried but we're getting the odd 404
|
||||
// which goes away on a retry for some reason.
|
||||
retryOnHttpResponse: (res) => res.status >= 400,
|
||||
},
|
||||
})
|
||||
.then((res) => {
|
||||
if (res.status !== 200) {
|
||||
throw new Error(
|
||||
// eslint-disable-next-line prettier/prettier
|
||||
`Could not download the icon ${icon} from ${url}: got status ${res.status}`,
|
||||
);
|
||||
}
|
||||
return res;
|
||||
})
|
||||
.then(
|
||||
(res) =>
|
||||
new Promise((resolve, reject) => {
|
||||
const fileStream = fs.createWriteStream(
|
||||
path.join(buildFolder, buildLocalIconPath(icon)),
|
||||
);
|
||||
res.body.pipe(fileStream);
|
||||
res.body.on('error', reject);
|
||||
fileStream.on('finish', resolve);
|
||||
}),
|
||||
);
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
// should match flipper-ui-core/src/utils/icons.tsx
|
||||
export function getPublicIconUrl({name, variant, size, density}: Icon) {
|
||||
return `https://facebook.com/assets/?name=${name}&variant=${variant}&size=${size}&set=facebook_icons&density=${density}x`;
|
||||
}
|
||||
|
||||
// should match app/src/utils/icons.tsx
|
||||
function buildLocalIconPath(icon: Icon) {
|
||||
return path.join(
|
||||
'icons',
|
||||
`${icon.name}-${icon.variant}-${icon.size}@${icon.density}x.png`,
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user