From 54b7d8feeadd3d5b57002b99bf739570e596eccf Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Mon, 3 Jul 2023 04:31:49 -0700
Subject: [PATCH] Fix react native windows (#4905)

Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4905

Use fully qualified names in an attempt to fix the broken build.

Reviewed By: passy

Differential Revision: D47148297

fbshipit-source-id: bb2e81f62a65b9d4516a0bc4cfe2abddfc18a566
---
 .../FlipperReactSocketClient.cpp              | 23 ++++++++-----------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/react-native/react-native-flipper/windows/ReactNativeFlipper/FlipperReactSocketClient.cpp b/react-native/react-native-flipper/windows/ReactNativeFlipper/FlipperReactSocketClient.cpp
index a2a29100a..d5a2c768b 100644
--- a/react-native/react-native-flipper/windows/ReactNativeFlipper/FlipperReactSocketClient.cpp
+++ b/react-native/react-native-flipper/windows/ReactNativeFlipper/FlipperReactSocketClient.cpp
@@ -178,17 +178,13 @@ void FlipperReactSocketClient::connect(FlipperConnectionManager* manager) {
   try {
     status_ = Status::Initializing;
 
-    Windows::Foundation::IAsyncAction ^ connectAction;
-    connectAction =
-        this->socket_.ConnectAsync(winrt::Windows::Foundation::Uri(uri));
-    connectAction->Completed = ref new AsyncActionCompletedHandler(
-        [eventHandler = eventHandler_](
-            Windows::Foundation::IAsyncAction ^ asyncAction,
-            Windows::Foundation::AsyncStatus asyncStatus) {
-          if (asyncStatus == Windows::Foundation::AsyncStatus::Completed) {
-            eventHandler(SocketEvent::OPEN);
+    this->socket_.ConnectAsync(winrt::Windows::Foundation::Uri(uri))
+        .Completed([&](auto&& asyncInfo, auto&& asyncStatus) {
+          if (asyncStatus ==
+              winrt::Windows::Foundation::AsyncStatus::Completed) {
+            eventHandler_(SocketEvent::OPEN);
           } else {
-            eventHandler(SocketEvent::ERROR);
+            eventHandler_(SocketEvent::ERROR);
           }
         });
 
@@ -198,7 +194,7 @@ void FlipperReactSocketClient::connect(FlipperConnectionManager* manager) {
             ex.to_abi())};
     socket_ = nullptr;
     status_ = Status::Unconnected;
-    eventHandler(SocketEvent::ERROR);
+    eventHandler_(SocketEvent::ERROR);
   }
 }
 
@@ -273,10 +269,11 @@ void FlipperReactSocketClient::OnWebSocketMessageReceived(
     const std::string payload = winrt::to_string(message);
 
     if (overrideHandler_ != nullptr) {
+      auto messageHandler = *overrideHandler_;
       messageHandler(payload, false);
       overrideHandler_ = nullptr;
     } else if (messageHandler_) {
-      messageHandler(payload);
+      messageHandler_(payload);
     }
   } catch (winrt::hresult_error const& ex) {
     // winrt::Windows::Web::WebErrorStatus webErrorStatus{
@@ -291,7 +288,7 @@ void FlipperReactSocketClient::OnWebSocketClosed(
     return;
   }
   status_ = Status::Closed;
-  eventHandler(SocketEvent::CLOSE);
+  eventHandler_(SocketEvent::CLOSE);
 }
 
 } // namespace flipper