From 5269800738d925bfcc22b59db15e9203bf4d4205 Mon Sep 17 00:00:00 2001 From: Anton Kastritskiy Date: Fri, 10 Nov 2023 09:34:52 -0800 Subject: [PATCH] remove metro button Reviewed By: lblasa Differential Revision: D51199560 fbshipit-source-id: ebd844a57b0b30859b186361136cc8a2f897d9f2 --- .../src/chrome/MetroButton.tsx | 94 ------------------- .../sandy-chrome/appinspect/AppInspect.tsx | 6 -- 2 files changed, 100 deletions(-) delete mode 100644 desktop/flipper-ui-core/src/chrome/MetroButton.tsx diff --git a/desktop/flipper-ui-core/src/chrome/MetroButton.tsx b/desktop/flipper-ui-core/src/chrome/MetroButton.tsx deleted file mode 100644 index 54652960a..000000000 --- a/desktop/flipper-ui-core/src/chrome/MetroButton.tsx +++ /dev/null @@ -1,94 +0,0 @@ -/** - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @format - */ - -import React, {useCallback, useEffect, useState} from 'react'; -import {MetroReportableEvent} from 'flipper-common'; -import {useStore} from '../utils/useStore'; -import {Button as AntButton} from 'antd'; -import {MenuOutlined, ReloadOutlined} from '@ant-design/icons'; -import {theme} from 'flipper-plugin'; -import {BaseDevice} from 'flipper-frontend-core'; - -export default function MetroButton() { - const device = useStore((state) => - state.connections.devices.find( - (device) => device.os === 'Metro' && device.connected.get(), - ), - ) as BaseDevice | undefined; - - const sendCommand = useCallback( - (command: string) => { - device?.sendMetroCommand(command); - }, - [device], - ); - const [progress, setProgress] = useState(1); - const [_hasBuildError, setHasBuildError] = useState(false); - - useEffect(() => { - if (!device) { - return; - } - function metroEventListener(event: MetroReportableEvent) { - if (event.type === 'bundle_build_started') { - setHasBuildError(false); - setProgress(0); - } else if (event.type === 'bundle_build_failed') { - setHasBuildError(true); - setProgress(1); - } else if (event.type === 'bundle_build_done') { - setHasBuildError(false); - setProgress(1); - } else if (event.type === 'bundle_transform_progressed') { - setProgress(event.transformedFileCount / event.totalFileCount); - } - } - - const handle = device.addLogListener((l) => { - if (l.tag !== 'client_log') { - try { - metroEventListener(JSON.parse(l.message)); - } catch (e) { - console.warn('Failed to parse metro message: ', l, e); - } - } - }); - - return () => { - device.removeLogListener(handle); - }; - }, [device]); - - if (!device) { - return null; - } - - return ( - <> - } - title="Reload React Native App" - type="ghost" - onClick={() => { - sendCommand('reload'); - }} - loading={progress < 1} - style={{color: _hasBuildError ? theme.errorColor : undefined}} - /> - } - title="Open the React Native Dev Menu on the device" - type="ghost" - onClick={() => { - sendCommand('devMenu'); - }} - /> - - ); -} diff --git a/desktop/flipper-ui-core/src/sandy-chrome/appinspect/AppInspect.tsx b/desktop/flipper-ui-core/src/sandy-chrome/appinspect/AppInspect.tsx index 72dcbb6dd..845d4dac9 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/appinspect/AppInspect.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/appinspect/AppInspect.tsx @@ -13,7 +13,6 @@ import {LeftSidebar, SidebarTitle} from '../LeftSidebar'; import {Layout, styled} from '../../ui'; import {theme, useValue} from 'flipper-plugin'; import {PluginList} from './PluginList'; -import MetroButton from '../../chrome/MetroButton'; import {BookmarkSection} from './BookmarkSection'; import Client from '../../Client'; import {BaseDevice} from 'flipper-frontend-core'; @@ -47,11 +46,6 @@ export function AppInspect() { {isDeviceConnected && isAppConnected && } - {isDeviceConnected && activeDevice && ( - - - - )}