jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Detect JSON API content type ('application/vnd.api+json') as textual content (#2337)

Browse Source 
Summary:
Network requests and responses using JSON API content type of pattern `application/vnd.api+json` (see https://jsonapi.org/#mime-types) are currently treated as binary data. They should be treated as textual content.

## Changelog

Add regular expression to detect JSON content types.

Pull Request resolved: https://github.com/facebook/flipper/pull/2337

Test Plan: Using an API that return `Content-Type` of pattern `application/vnd.api+json`, verify that the response data in sidebar appears as text rather than `(binary data)`.

Reviewed By: passy

Differential Revision: D28513547

Pulled By: mweststrate

fbshipit-source-id: 3335b7eeb63c2429c2245113c8c83bd7e08a9420
This commit is contained in:
Denis Colliot
2021-05-18 13:47:16 -07:00
committed by Facebook GitHub Bot
parent 4cdc72aba4
commit 525e8b19fb
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
desktop/plugins/public/network/utils.tsx
View File

@@ -26,6 +26,9 @@ export function getHeaderValue(
return ''; return '';
} }
// Matches `application/json` and `application/vnd.api.v42+json` (see https://jsonapi.org/#mime-types)
const jsonContentTypeRegex = new RegExp('application/(json|.+\\+json)');
export function isTextual(headers?: Array<Header>): boolean { export function isTextual(headers?: Array<Header>): boolean {
const contentType = getHeaderValue(headers, 'Content-Type'); const contentType = getHeaderValue(headers, 'Content-Type');
if (!contentType) { if (!contentType) {
@@ -36,7 +39,7 @@ export function isTextual(headers?: Array<Header>): boolean {
return ( return (
contentType.startsWith('text/') || contentType.startsWith('text/') ||
contentType.startsWith('application/x-www-form-urlencoded') || contentType.startsWith('application/x-www-form-urlencoded') ||
contentType.startsWith('application/json') || jsonContentTypeRegex.test(contentType) ||
contentType.startsWith('multipart/') || contentType.startsWith('multipart/') ||
contentType.startsWith('message/') || contentType.startsWith('message/') ||
contentType.startsWith('image/svg') || contentType.startsWith('image/svg') ||