jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Implement deeplink, creating pastes, log deduplication

Browse Source 
Summary:
This diff implements the remaining features in the logs plugin:

- deeplinking
- merging duplicate rows

The logs plugin source code has now been reduced from originally `935` to `285` LoC. All optimisation code has been removed from the plugin:

* debouncing data processing
* pre-rendering (and storing!) all rows

Finally applied some further styling tweaks and applied some renames to DataTable / DataSource + types finetuning. Some more will follow.
Fixed a emotion warning in unit tests which was pretty annoying.

Reviewed By: passy

Differential Revision: D26666190

fbshipit-source-id: e45e289b4422ebeb46cad927cfc0cfcc9566834f
This commit is contained in:
Michel Weststrate
2021-03-16 14:54:53 -07:00
committed by Facebook GitHub Bot
parent dec8e88aeb
commit 525e079284
17 changed files with 132 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
desktop/flipper-plugin/src/ui/datatable/__tests__/DataTable.node.tsx
View File

@@ -11,7 +11,7 @@ import React, {createRef} from 'react';
import {DataTable, DataTableColumn} from '../DataTable';
import {render, act} from '@testing-library/react';
import {createDataSource} from '../../../state/datasource/DataSource';
import {computeDataTableFilter, TableManager} from '../useDataTableManager';
import {computeDataTableFilter, DataTableManager} from '../useDataTableManager';
import {Button} from 'antd';
type Todo = {
@@ -41,7 +41,7 @@ const columns: DataTableColumn[] = [
test('update and append', async () => {
const ds = createTestDataSource();
const ref = createRef<TableManager>();
const ref = createRef<DataTableManager<Todo>>();
const rendering = render(
<DataTable
dataSource={ds}
@@ -55,15 +55,15 @@ test('update and append', async () => {
expect(elem.length).toBe(1);
expect(elem[0].parentElement).toMatchInlineSnapshot(`
<div
class="css-8pa5c2-TableBodyRowContainer efe0za01"
class="css-1b7miqb-TableBodyRowContainer efe0za01"
>
<div
class="css-kkcfb6-TableBodyColumnContainer efe0za00"
class="css-bqa56k-TableBodyColumnContainer efe0za00"
>
test DataTable
</div>
<div
class="css-kkcfb6-TableBodyColumnContainer efe0za00"
class="css-bqa56k-TableBodyColumnContainer efe0za00"
>
true
</div>
@@ -98,7 +98,7 @@ test('update and append', async () => {
test('column visibility', async () => {
const ds = createTestDataSource();
const ref = createRef<TableManager>();
const ref = createRef<DataTableManager<Todo>>();
const rendering = render(
<DataTable
dataSource={ds}
@@ -112,15 +112,15 @@ test('column visibility', async () => {
expect(elem.length).toBe(1);
expect(elem[0].parentElement).toMatchInlineSnapshot(`
<div
class="css-8pa5c2-TableBodyRowContainer efe0za01"
class="css-1b7miqb-TableBodyRowContainer efe0za01"
>
<div
class="css-kkcfb6-TableBodyColumnContainer efe0za00"
class="css-bqa56k-TableBodyColumnContainer efe0za00"
>
test DataTable
</div>
<div
class="css-kkcfb6-TableBodyColumnContainer efe0za00"
class="css-bqa56k-TableBodyColumnContainer efe0za00"
>
true
</div>
@@ -137,10 +137,10 @@ test('column visibility', async () => {
expect(elem.length).toBe(1);
expect(elem[0].parentElement).toMatchInlineSnapshot(`
<div
class="css-8pa5c2-TableBodyRowContainer efe0za01"
class="css-1b7miqb-TableBodyRowContainer efe0za01"
>
<div
class="css-kkcfb6-TableBodyColumnContainer efe0za00"
class="css-bqa56k-TableBodyColumnContainer efe0za00"
>
test DataTable
</div>
@@ -174,7 +174,7 @@ test('sorting', async () => {
title: 'item b',
done: false,
});
const ref = createRef<TableManager>();
const ref = createRef<DataTableManager<Todo>>();
const rendering = render(
<DataTable
dataSource={ds}
@@ -195,7 +195,7 @@ test('sorting', async () => {
}
// sort asc
act(() => {
ref.current?.sortColumn('title', 'down');
ref.current?.sortColumn('title', 'asc');
});
{
const elem = await rendering.findAllByText(/item/);
@@ -208,7 +208,7 @@ test('sorting', async () => {
}
// sort desc
act(() => {
ref.current?.sortColumn('title', 'up');
ref.current?.sortColumn('title', 'desc');
});
{
const elem = await rendering.findAllByText(/item/);
@@ -249,7 +249,7 @@ test('search', async () => {
title: 'item b',
done: false,
});
const ref = createRef<TableManager>();
const ref = createRef<DataTableManager<Todo>>();
const rendering = render(
<DataTable
dataSource={ds}
@@ -514,7 +514,7 @@ test('compute filters', () => {
test('onSelect callback fires, and in order', () => {
const events: any[] = [];
const ds = createTestDataSource();
const ref = createRef<TableManager>();
const ref = createRef<DataTableManager<Todo>>();
const rendering = render(
<DataTable
dataSource={ds}
@@ -566,7 +566,7 @@ test('onSelect callback fires, and in order', () => {
test('selection always has the latest state', () => {
const events: any[] = [];
const ds = createTestDataSource();
const ref = createRef<TableManager>();
const ref = createRef<DataTableManager<Todo>>();
const rendering = render(
<DataTable
dataSource={ds}