jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix GitHub Actions for sample build (#1693)

Browse Source 
Summary:
Honestly not sure what's causing the new NDK to be pulled in
but at least locally installing it fixes the failure we see here:

https://github.com/facebook/flipper/runs/1424681947

Pull Request resolved: https://github.com/facebook/flipper/pull/1693

Test Plan: Wait for the Actions on the PR

Reviewed By: nikoant

Differential Revision: D25093335

Pulled By: passy

fbshipit-source-id: e7af63fcf3c5270c869acc3d094234d15968aeda
This commit is contained in:
Pascal Hartig
2020-11-19 12:24:03 -08:00
committed by Facebook GitHub Bot
parent 8b5220d8b3
commit 51de9b72cf
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/android-sample.yml vendored
View File

@@ -13,8 +13,8 @@ jobs:
uses: actions/setup-java@v1 uses: actions/setup-java@v1
with: with:
java-version: 1.8 java-version: 1.8
- name: Install NDK 20 - name: Install NDK 21
run: echo "y" | sudo /usr/local/lib/android/sdk/tools/bin/sdkmanager --install "ndk;20.0.5594570" --sdk_root=${ANDROID_SDK_ROOT} run: echo "y" | sudo /usr/local/lib/android/sdk/tools/bin/sdkmanager --install "ndk;21.0.6113669" --sdk_root=${ANDROID_SDK_ROOT}
- name: Build with Gradle - name: Build with Gradle
run: ./gradlew :sample:assembleDebug :tutorial:assembleDebug run: ./gradlew :sample:assembleDebug :tutorial:assembleDebug
- name: upload artifact - name: upload artifact

4
.github/workflows/android.yml vendored
View File

@@ -15,8 +15,8 @@ jobs:
uses: actions/setup-java@v1 uses: actions/setup-java@v1
with: with:
java-version: 1.8 java-version: 1.8
- name: Install NDK 20 - name: Install NDK 21
run: echo "y" | sudo /usr/local/lib/android/sdk/tools/bin/sdkmanager --install "ndk;20.0.5594570" --sdk_root=${ANDROID_SDK_ROOT} run: echo "y" | sudo /usr/local/lib/android/sdk/tools/bin/sdkmanager --install "ndk;21.0.6113669" --sdk_root=${ANDROID_SDK_ROOT}
- name: Build with Gradle - name: Build with Gradle
run: ./gradlew :sample:assembleDebug :sample:assembleRelease run: ./gradlew :sample:assembleDebug :sample:assembleRelease
- name: Rename apk - name: Rename apk