Update Sonar from 0.69.0 to 0.70.0

Summary:
All the new errors were missing annotation errors. I fixed as many as I could
by adding annotations. For the rest I added a $FlowFixMe suppression type.

Reviewed By: nmote

Differential Revision: D8756267

fbshipit-source-id: a69b6e21525b9b12e582ff18dcb1eeea584abb2a
This commit is contained in:
Sam Goldman
2018-07-06 15:57:14 -07:00
committed by Facebook Github Bot
parent d45bc14cce
commit 51741a2741
6 changed files with 9 additions and 7 deletions

View File

@@ -19,5 +19,7 @@ all=true
include_warnings=true include_warnings=true
module.name_mapper='sonar' -> '<PROJECT_ROOT>/src/index.js' module.name_mapper='sonar' -> '<PROJECT_ROOT>/src/index.js'
suppress_type=$FlowFixMe
[version] [version]
0.69.0 0.70.0

View File

@@ -486,7 +486,7 @@ export default class LogTable extends SonarDevicePlugin<LogsState> {
createPaste(paste); createPaste(paste);
}; };
setTableRef = (ref: React.ElementRef<*>) => { setTableRef = (ref: React.ElementRef<typeof ManagedTable>) => {
this.tableRef = ref; this.tableRef = ref;
}; };

View File

@@ -233,7 +233,6 @@ export default class Layout extends SonarPlugin<InspectorState> {
for (const element of elements) { for (const element of elements) {
const current = updatedElements[element.id] || {}; const current = updatedElements[element.id] || {};
// $FlowFixMe
updatedElements[element.id] = { updatedElements[element.id] = {
...current, ...current,
...element, ...element,
@@ -248,7 +247,6 @@ export default class Layout extends SonarPlugin<InspectorState> {
for (const element of elements) { for (const element of elements) {
const current = updatedElements[element.id] || {}; const current = updatedElements[element.id] || {};
// $FlowFixMe
updatedElements[element.id] = { updatedElements[element.id] = {
...current, ...current,
...element, ...element,

View File

@@ -26,6 +26,8 @@ import FlexRow from '../FlexRow.js';
const invariant = require('invariant'); const invariant = require('invariant');
type MenuTemplate = Array<Electron$MenuItemOptions>;
const TableHeaderArrow = styled.text({ const TableHeaderArrow = styled.text({
float: 'right', float: 'right',
}); });
@@ -198,7 +200,7 @@ export default class TableHead extends PureComponent<{
columnSizes: TableColumnSizes, columnSizes: TableColumnSizes,
onColumnResize: ?TableOnColumnResize, onColumnResize: ?TableOnColumnResize,
}> { }> {
buildContextMenu = () => { buildContextMenu = (): MenuTemplate => {
return Object.keys(this.props.columns).map(key => { return Object.keys(this.props.columns).map(key => {
const visible = this.props.columnKeys.includes(key); const visible = this.props.columnKeys.includes(key);
return { return {

View File

@@ -86,7 +86,7 @@ export class GarbageCollector {
} }
} }
getCollectionQueue() { getCollectionQueue(): Array<string> {
return Array.from(this.classRemovalQueue); return Array.from(this.classRemovalQueue);
} }

View File

@@ -6,7 +6,7 @@
*/ */
// list of icons that are prefetched in the service worker when launching the app // list of icons that are prefetched in the service worker when launching the app
export const precachedIcons = [ export const precachedIcons: Array<string> = [
{ {
name: 'arrow-right', name: 'arrow-right',
size: 12, size: 12,