Fix the callstack sent from error reporting runnable
Summary:
The crash logged from `ErrorReporterRunnable` wasn't detailed. For example look at the following video.
Also for some reason the `FlipperConnection` interface doesn't have an argument for crash name. Thus I changed the js side of the plugin to accept `crash.name` to be undefined.
{F155526537}
Reviewed By: passy
Differential Revision: D14852561
fbshipit-source-id: 6daf9847535b4508fa312b4f940b014911aae2e5
This commit is contained in:
committed by
Facebook Github Bot
parent
9e4a9607b5
commit
5169d318de
@@ -318,8 +318,11 @@ public class InspectorFlipperPluginTest {
|
||||
new FlipperObject.Builder().put("ids", new FlipperArray.Builder().put("test")).build(),
|
||||
responder);
|
||||
|
||||
assertThat(connection.errors.size(), equalTo(1));
|
||||
assertThat(
|
||||
connection.errors, CoreMatchers.hasItem(hasThrowableWithMessage("Unexpected null value")));
|
||||
connection.errors,
|
||||
CoreMatchers.hasItem(
|
||||
hasThrowableWithMessage("java.lang.RuntimeException: Unexpected null value")));
|
||||
}
|
||||
|
||||
private class TestNode {
|
||||
|
||||
Reference in New Issue
Block a user