From 4fdfbdc8df685ea6b5234aae916b7ff47f9d6a16 Mon Sep 17 00:00:00 2001
From: Luke De Feo <lukedefeo@meta.com>
Date: Thu, 27 Apr 2023 07:28:41 -0700
Subject: [PATCH] Open in IDE for bloks derived components

Summary:
* Added line number as an attribute to node, in theory we could get it from the device in the case of compose
* dont need to use miles as have the file already
* cleaned up naming in ide file resolver so its clear its the qualified name we are talking about

Reviewed By: lblasa

Differential Revision: D45079135

fbshipit-source-id: 24f2d5814800a4a404b680599d307cc750758fcd
---
 .../components/sidebar/inspector/IdentityInspector.tsx       | 3 ++-
 .../components/sidebar/inspector/fb-stubs/CodeInspector.tsx  | 3 ++-
 desktop/plugins/public/ui-debugger/types.tsx                 | 5 +++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/desktop/plugins/public/ui-debugger/components/sidebar/inspector/IdentityInspector.tsx b/desktop/plugins/public/ui-debugger/components/sidebar/inspector/IdentityInspector.tsx
index a51082868..aecfb8211 100644
--- a/desktop/plugins/public/ui-debugger/components/sidebar/inspector/IdentityInspector.tsx
+++ b/desktop/plugins/public/ui-debugger/components/sidebar/inspector/IdentityInspector.tsx
@@ -42,9 +42,10 @@ export const IdentityInspector: React.FC<Props> = ({node}) => {
       </Row>
 
       <CodeInspector
-        name={node.qualifiedName}
+        qualifiedName={node.qualifiedName}
         tags={node.tags}
         androidId={node.inlineAttributes['id']}
+        lineNumber={node.lineNumber}
       />
     </IdentityContainer>
   );
diff --git a/desktop/plugins/public/ui-debugger/components/sidebar/inspector/fb-stubs/CodeInspector.tsx b/desktop/plugins/public/ui-debugger/components/sidebar/inspector/fb-stubs/CodeInspector.tsx
index 732d174cc..aa9ec5ab2 100644
--- a/desktop/plugins/public/ui-debugger/components/sidebar/inspector/fb-stubs/CodeInspector.tsx
+++ b/desktop/plugins/public/ui-debugger/components/sidebar/inspector/fb-stubs/CodeInspector.tsx
@@ -12,7 +12,8 @@ import {Tag} from '../../../../types';
 
 type CodeInspectorProps = {
   tags: Tag[];
-  name: string;
+  qualifiedName: string;
+  lineNumber?: number;
   androidId?: string;
 };
 export const CodeInspector: React.FC<CodeInspectorProps> = () => {
diff --git a/desktop/plugins/public/ui-debugger/types.tsx b/desktop/plugins/public/ui-debugger/types.tsx
index e27310780..3f88ad2ca 100644
--- a/desktop/plugins/public/ui-debugger/types.tsx
+++ b/desktop/plugins/public/ui-debugger/types.tsx
@@ -115,8 +115,9 @@ export type NestedNode = {
 
 export type UINode = {
   id: Id;
-  parent?: Id; //this attribute doesn't come from the client and is set by the desktop
-  qualifiedName: string;
+  parent?: Id;
+  qualifiedName: string; //this is the name of the component plus qualification so myles has a chance of finding it. E.g com.facebook.MyView
+  lineNumber?: number;
   name: string;
   attributes: Record<MetadataId, Inspectable>;
   inlineAttributes: Record<string, string>;