From 4faac01448a049f2ca5c5fbf7fbb9c37e327aecb Mon Sep 17 00:00:00 2001 From: John Knox Date: Fri, 22 Nov 2019 10:50:32 -0800 Subject: [PATCH] Fix initHybrid app-crashing bug Summary: We're seeing some cases of initHybrid failing when the C++ class hasn't been registered. I don't think we should be attempting to init in these cases, so gating it by the same logic as when we load the static library. Reviewed By: priteshrnandgaonkar Differential Revision: D18658101 fbshipit-source-id: b29592135dcf637a8c0d40aee30e383f4f35e527 --- .../src/main/java/com/facebook/flipper/android/EventBase.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/facebook/flipper/android/EventBase.java b/android/src/main/java/com/facebook/flipper/android/EventBase.java index 8a090dac6..b3b703fac 100644 --- a/android/src/main/java/com/facebook/flipper/android/EventBase.java +++ b/android/src/main/java/com/facebook/flipper/android/EventBase.java @@ -21,7 +21,9 @@ class EventBase extends HybridClassBase { } EventBase() { - initHybrid(); + if (BuildConfig.IS_INTERNAL_BUILD) { + initHybrid(); + } } @DoNotStrip