jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Omit invisible columns from horizontallyScrollable ManagedTables' width

Browse Source 
Summary: Currently, `horizontallyScrollable` logic includes even invisible columns in the width calculation for `horizontallyScrollable` `ManagedTable`s, resulting in large empty spaces when many columns are invisible.

Reviewed By: danielbuechele

Differential Revision: D16139713

fbshipit-source-id: f653121845fbeac8a29bdb67ad0309add28e526a
This commit is contained in:
Edward Pastuszenski
2019-07-09 10:04:04 -07:00
committed by Facebook Github Bot
parent 385d9ded57
commit 4f4d9fa76e
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/ui/components/table/ManagedTable.js
View File

@@ -650,8 +650,14 @@ class ManagedTable extends React.Component<
let computedWidth = 0; let computedWidth = 0;
if (horizontallyScrollable) { if (horizontallyScrollable) {
for (const col in columnSizes) { for (let index = 0; index < columnOrder.length; index++) {
const width = columnSizes[col]; const col = columnOrder[index];
if (!col.visible) {
continue;
}
const width = columnSizes[col.key];
if (isNaN(width)) { if (isNaN(width)) {
// non-numeric columns with, can't caluclate // non-numeric columns with, can't caluclate
computedWidth = 0; computedWidth = 0;