jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bug with multiple handling of deep link after window reload

Browse Source 
Summary: This diff fixed the issue when deep link handled multiple times in case Flipper window reloaded. See test plan for videos.

Reviewed By: fabiomassimo

Differential Revision: D29100221

fbshipit-source-id: 0ff6f1a645d5488d205b4fba44942f4d39f59088
This commit is contained in:
Anton Nikolaev
2021-06-14 06:50:08 -07:00
committed by Facebook GitHub Bot
parent bb9baef07a
commit 4cafa9ab1a
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
desktop/static/main.ts
View File

@@ -113,6 +113,7 @@ let win: BrowserWindow;
let appReady = false; let appReady = false;
let deeplinkURL: string | undefined = argv.url; let deeplinkURL: string | undefined = argv.url;
let filePath: string | undefined = argv.file; let filePath: string | undefined = argv.file;
let didMount = false;
// tracking // tracking
setInterval(() => { setInterval(() => {
@@ -151,10 +152,11 @@ app.on('will-finish-launching', () => {
// Protocol handler for osx // Protocol handler for osx
app.on('open-url', function (event, url) { app.on('open-url', function (event, url) {
event.preventDefault(); event.preventDefault();
deeplinkURL = url;
argv.url = url; argv.url = url;
if (win) { if (win && didMount) {
win.webContents.send('flipper-protocol-handler', deeplinkURL); win.webContents.send('flipper-protocol-handler', url);
} else {
deeplinkURL = url;
} }
}); });
app.on('open-file', (event, path) => { app.on('open-file', (event, path) => {
@@ -245,6 +247,7 @@ app.on('will-quit', () => {
}); });
ipcMain.on('componentDidMount', (_event) => { ipcMain.on('componentDidMount', (_event) => {
didMount = true;
if (deeplinkURL) { if (deeplinkURL) {
win.webContents.send('flipper-protocol-handler', deeplinkURL); win.webContents.send('flipper-protocol-handler', deeplinkURL);
deeplinkURL = undefined; deeplinkURL = undefined;