Differentiate enabled and disabled selected plugins in analytics
Summary: As we now allow selection of disabled plugins we need to track plugin usage a bit smarter. We'll add a new field "pluginEnabled" to the logged messages to indicate whether selected plugin is enabled or not. Reviewed By: cekkaewnumchai Differential Revision: D29455248 fbshipit-source-id: 32c79e0961653edc8f4cc89adecc2662b37cbd7b
This commit is contained in:
committed by
Facebook GitHub Bot
parent
142859f0ed
commit
4ad7a70ee3
@@ -15,6 +15,7 @@ const layoutSelection: SelectionInfo = {
|
||||
plugin: 'Layout',
|
||||
pluginName: 'flipper-plugin-layout',
|
||||
pluginVersion: '0.0.0',
|
||||
pluginEnabled: true,
|
||||
app: 'Facebook',
|
||||
device: 'test device',
|
||||
deviceName: 'test device',
|
||||
|
||||
@@ -84,15 +84,8 @@ export default (store: Store, logger: Logger) => {
|
||||
noTimeBudgetWarns: true,
|
||||
runSynchronously: true,
|
||||
},
|
||||
(state) => ({
|
||||
connections: state.connections,
|
||||
loadedPlugins: state.plugins.loadedPlugins,
|
||||
}),
|
||||
(state, store) => {
|
||||
const selection = getSelectionInfo(
|
||||
state.connections,
|
||||
state.loadedPlugins,
|
||||
);
|
||||
getSelectionInfo,
|
||||
(selection, store) => {
|
||||
const time = Date.now();
|
||||
store.dispatch(selectionChanged({selection, time}));
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user