jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refine DataSource id to use actual key type instead of a wide string type

Browse Source 
Summary: Current implementation uses type `string` as a key for indexing items stored in datasource. However, users can provide any key as an index which means that the type of index item can be anything, not only string. This diff introduces a more refined types for the key. It adds another requirement to provide a key property to a generic which is used to infer the index type.

Reviewed By: mweststrate, aigoncharov

Differential Revision: D31895751

fbshipit-source-id: 19ba907bd6f35df87e3fa442db5fc5cec6af174d
This commit is contained in:
Anton Kastritskiy
2021-10-28 10:42:49 -07:00
committed by Facebook GitHub Bot
parent 64e791e253
commit 4a4cc21d89
13 changed files with 99 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-plugin/src/data-source/__tests__/datasource-perf.node.tsx
View File

@@ -32,7 +32,7 @@ function generateTodos(amount: number): Todo[] {
const defaultFilter = (t: Todo) => !t.done;
type DataSourceish = DataSource<Todo> | FakeDataSource<Todo>;
type DataSourceish = DataSource<Todo, Todo[keyof Todo]> | FakeDataSource<Todo>;
// NOTE: this run in jest, which is not optimal for perf, but should give some idea
// make sure to use the `yarn watch` script in desktop root, so that the garbage collector is exposed