jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Custom eslint rule for disallowing cross-package references

Browse Source 
Summary:
Added infra for writing and using custom eslint rules and created a rule for disallowing cross-package file imports. Such imports are anti-pattern and they also break standalone plugin bundling.

We still have a bunch of places where Flipper core references code directly from plugins. I've ignored these places for now and added task T71355623 to revisit them.

Reviewed By: passy

Differential Revision: D22998955

fbshipit-source-id: d04cff8fc115ba1300a7e6830306ec134046e927
This commit is contained in:
Anton Nikolaev
2020-08-07 10:19:34 -07:00
committed by Facebook GitHub Bot
parent 6989fa608d
commit 4a1c2a9ece
17 changed files with 428 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
desktop/package.json
View File

@@ -28,7 +28,8 @@
"plugins/*",
"e2e",
"plugin-lib",
"test-utils"
"test-utils",
"eslint-plugin-flipper"
],
"nohoist": [
"flipper-plugin-kaios-big-allocations/firefox-client"
@@ -108,6 +109,7 @@
},
"devDependencies": {
"@babel/code-frame": "^7.10.4",
"@babel/eslint-parser": "^7.11.0",
"@jest-runner/electron": "^3.0.0",
"@testing-library/dom": "^7.20.2",
"@testing-library/react": "^10.4.3",
@@ -173,6 +175,7 @@
"eslint-config-prettier": "^6.10.1",
"eslint-import-resolver-typescript": "^2.0.0",
"eslint-plugin-babel": "^5.3.0",
"eslint-plugin-flipper": "0.52.1",
"eslint-plugin-flowtype": "^4.7.0",
"eslint-plugin-header": "^3.0.0",
"eslint-plugin-import": "^2.22.0",
@@ -219,7 +222,7 @@
},
"scripts": {
"preinstall": "node scripts/prepare-watchman-config.js && yarn config set ignore-engines",
"postinstall": "patch-package && ./ts-node scripts/yarn-install-fb-plugins.ts && yarn build:pkg && ./ts-node scripts/generate-plugin-entry-points.ts",
"postinstall": "patch-package && ./ts-node scripts/yarn-install-fb-plugins.ts && yarn build:pkg && yarn build:eslint && ./ts-node scripts/generate-plugin-entry-points.ts",
"rm-dist": "rimraf ../dist",
"rm-modules": "rimraf **/*/node_modules node_modules",
"rm-temp": "rimraf $TMPDIR/jest* $TMPDIR/react-native-packager*",
@@ -234,6 +237,7 @@
"start:no-embedded-plugins": "yarn start --no-embedded-plugins",
"build:babel-transformer": "cd babel-transformer && yarn build",
"build:pkg": "cd pkg && yarn build",
"build:eslint": "cd eslint-plugin-flipper && yarn build",
"prebuild": "yarn build:pkg && yarn rm-dist",
"build": "cross-env NODE_ENV=production ./ts-node scripts/build-release.ts $@",
"build:dev": "cross-env NODE_ENV=development ./ts-node scripts/build-release.ts $@",
@@ -252,6 +256,7 @@
"test-with-device": "yarn build:pkg && USE_ELECTRON_STUBS=1 jest --testMatch=\"**/**.device\\.(js|jsx|ts|tsx)\" --detectOpenHandles",
"test-e2e": "cd e2e && yarn test",
"lint:tsc": "tsc --noemit",
"prelint:eslint": "yarn build:eslint",
"lint:eslint": "eslint . --ext .js,.ts,.tsx",
"lint:flow": "flow check",
"lint": "yarn lint:eslint && yarn lint:flow && yarn lint:tsc",