From 49e7f2dc8b139e95606e02dd69b71c65bcc4b81e Mon Sep 17 00:00:00 2001
From: John Knox <jknox@fb.com>
Date: Tue, 9 Oct 2018 08:22:23 -0700
Subject: [PATCH] Add notifications for failed network requests

Summary: Also acts as a model for using the computeNotifications api.

Reviewed By: passy

Differential Revision: D10240659

fbshipit-source-id: 610512de7484e10c9c0ed8e661913c2fe10869da
---
 src/plugins/network/index.js | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/src/plugins/network/index.js b/src/plugins/network/index.js
index 0ab7735dd..eb04f6bb3 100644
--- a/src/plugins/network/index.js
+++ b/src/plugins/network/index.js
@@ -7,6 +7,7 @@
 
 import type {TableHighlightedRows, TableRows, TableBodyRow} from 'flipper';
 
+import type {NotificationSet} from '../../plugin';
 import {
   ContextMenu,
   FlexColumn,
@@ -152,6 +153,26 @@ export default class extends FlipperPlugin<State, *, PersistedState> {
     this.props.setPersistedState({responses: {}, requests: {}});
   };
 
+  computeNotifications(props: *, state: State) {
+    const notifications: NotificationSet = {};
+    const persistedState = props.persistedState;
+    for (const response in persistedState.responses) {
+      const status = persistedState.responses[response].status;
+      if (status >= 400) {
+        const url = persistedState.requests[response]?.url;
+        const startTime = persistedState.requests[response]?.timestamp;
+        const endTime = persistedState.responses[response].timestamp;
+        notifications[`${url}-${startTime}`] = {
+          timestamp: endTime,
+          title: 'Failed network request',
+          message: `Response for ${url} failed with status code ${status}`,
+          severity: 'error',
+        };
+      }
+    }
+    return notifications;
+  }
+
   renderSidebar = () => {
     const {requests, responses} = this.props.persistedState;
     const {selectedIds} = this.state;