Show framework event metadata documentation in detail view and tree select

Reviewed By: lblasa

Differential Revision: D48348090

fbshipit-source-id: e48547508b78178b278f72ce72fc579c9f015570
This commit is contained in:
Luke De Feo
2023-08-21 04:24:16 -07:00
committed by Facebook GitHub Bot
parent f5bc03c263
commit 4918d21df8
5 changed files with 82 additions and 13 deletions

View File

@@ -17,7 +17,7 @@ import {
SearchOutlined,
} from '@ant-design/icons';
import {usePlugin, useValue, Layout} from 'flipper-plugin';
import {FrameworkEventType} from '../../ClientTypes';
import {FrameworkEventMetadata, FrameworkEventType} from '../../ClientTypes';
import {
buildTreeSelectData,
FrameworkEventsTreeSelect,
@@ -35,6 +35,8 @@ export const TreeControls: React.FC = () => {
instance.uiState.frameworkEventMonitoring,
);
const frameworkEventMetadata = useValue(instance.frameworkEventMetadata);
const [showFrameworkEventsModal, setShowFrameworkEventsModal] =
useState(false);
@@ -72,6 +74,7 @@ export const TreeControls: React.FC = () => {
</Tooltip>
}></Button>
<FrameworkEventsMonitoringModal
metadata={frameworkEventMetadata}
filterMainThreadMonitoring={filterMainThreadMonitoring}
onSetFilterMainThreadMonitoring={
instance.uiActions.onSetFilterMainThreadMonitoring
@@ -96,7 +99,9 @@ function FrameworkEventsMonitoringModal({
onSetFilterMainThreadMonitoring,
filterMainThreadMonitoring,
frameworkEventTypes,
metadata,
}: {
metadata: Map<FrameworkEventType, FrameworkEventMetadata>;
visible: boolean;
onCancel: () => void;
onSetEventMonitored: (
@@ -113,6 +118,7 @@ function FrameworkEventsMonitoringModal({
const treeData = buildTreeSelectData(
frameworkEventTypes.map(([type]) => type),
metadata,
);
return (