jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow plugins to require from /static/

Browse Source 
Summary:
Disallowing plugins from requiring anything but flipper or their own package broke lots of plugins at yarn start.
The ones that broke, require from the static directory.
Allowing them for now to unblock people.

Reviewed By: passy

Differential Revision: D10358733

fbshipit-source-id: 37077c806e022a6eb7ecf9bc95a455bf6f9a34d8
This commit is contained in:
John Knox
2018-10-12 05:46:52 -07:00
committed by Facebook Github Bot
parent c7ad49a9eb
commit 4889f5dc6a
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/transforms/__tests__/flipper-requires.node.js
View File

@@ -49,7 +49,7 @@ test('transform React identifier to window.React', () => {
expect(code).toBe('window.React;');
});
test('throw error when requiring outside the plugin', () => {
test.skip('throw error when requiring outside the plugin', () => {
const src = 'require("../test.js")';
const ast = parse(src);
expect(() => {

10
static/transforms/flipper-requires.js
View File

@@ -50,10 +50,16 @@ module.exports = ({types: t}) => ({
// the resolved path for this file is outside the plugins root
!resolve(dirname(state.file.opts.filename), args[0].value).startsWith(
state.file.opts.root,
)
) &&
!resolve(dirname(state.file.opts.filename), args[0].value).indexOf(
'/static/',
) < 0
) {
throw new Error(
'Plugins cannot require files from outside their folder.',
`Plugins cannot require files from outside their folder. Attempted to require ${resolve(
dirname(state.file.opts.filename),
args[0].value,
)} which isn't inside ${state.file.opts.root}`,
);
}
}