jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix NPE in ios sdk

Browse Source 
Summary: Haven't been able to repro this, but from the stack trace it seems like this NSData object is null in some cases: https://www.internalfb.com/logview/details/instagram_ios_crashes/d0e929eae516ec48380518380cfca9f5/?selected-logview-tab=Employee+Traces

Reviewed By: lblasa

Differential Revision: D37995141

fbshipit-source-id: 937217a7a5b1c7cc992f3f9ca5dc3a7e31165d1c
This commit is contained in:
John Knox
2022-07-21 05:34:07 -07:00
committed by Facebook GitHub Bot
parent a9aabba042
commit 485083750e
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
iOS/FlipperKit/FlipperPlatformWebSocket.mm
View File

@@ -60,6 +60,9 @@ static constexpr int connectionKeepaliveSeconds = 10;
NSString* certificatePathObjC = NSString* certificatePathObjC =
[NSString stringWithUTF8String:certificatePath.c_str()]; [NSString stringWithUTF8String:certificatePath.c_str()];
NSData* certificateData = [NSData dataWithContentsOfFile:certificatePathObjC]; NSData* certificateData = [NSData dataWithContentsOfFile:certificatePathObjC];
if (!certificateData) {
return;
}
NSString* password = [NSString stringWithUTF8String:PASSWORD]; NSString* password = [NSString stringWithUTF8String:PASSWORD];
NSDictionary* optionsDictionary = [NSDictionary NSDictionary* optionsDictionary = [NSDictionary