From 4784c45778384c990707066e89b6fa3ffd3a6705 Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Mon, 16 Mar 2020 05:20:11 -0700 Subject: [PATCH] Make view scrollable if error message is long Summary: Bug: {F231521873} Reviewed By: mweststrate Differential Revision: D20460428 fbshipit-source-id: 1ea7cbef2bd7c173defd0b056641abc87e66f93c --- desktop/src/chrome/ShareSheetErrorList.tsx | 2 +- desktop/src/ui/components/View.tsx | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/desktop/src/chrome/ShareSheetErrorList.tsx b/desktop/src/chrome/ShareSheetErrorList.tsx index e4f6a8eb1..fe47efcc6 100644 --- a/desktop/src/chrome/ShareSheetErrorList.tsx +++ b/desktop/src/chrome/ShareSheetErrorList.tsx @@ -46,7 +46,7 @@ export default class Popover extends PureComponent { return null; } return ( - + The following errors occurred while exporting your data diff --git a/desktop/src/ui/components/View.tsx b/desktop/src/ui/components/View.tsx index 26310b7c3..5d9fa41f0 100644 --- a/desktop/src/ui/components/View.tsx +++ b/desktop/src/ui/components/View.tsx @@ -12,6 +12,7 @@ import styled from '@emotion/styled'; type Props = { grow?: boolean; scrollable?: boolean; + maxHeight?: number; }; const View = styled.div<Props>(props => ({ @@ -19,6 +20,7 @@ const View = styled.div<Props>(props => ({ overflow: props.scrollable ? 'auto' : 'visible', position: 'relative', width: props.grow ? '100%' : 'auto', + maxHeight: props.maxHeight, })); View.displayName = 'View';