Upgrade folly to v2020.02.17.00 (#809)
Summary: # Summary Folly became once again incompatible with the Android NDK, which caused our CI to fail to produce sample APK builds on release. I managed to repro this on my machine and it's working again now. Sadly, I had to patch another file manually because something about the template parameter inference wasn't working ... # Notes This was done by first bumping the version, then going through the compiler errors and simply removing the lines that the C++ compiler in the NDK had trouble inferring the types for. We were lucky in that the exported symbols this affected weren't actually used, so I copied over the file to `overrides/Folly/` and set up another copy rule in Gradle. # Meta Pull Request resolved: https://github.com/facebook/flipper/pull/809 Test Plan: ``` ./gradlew :sample:assembleDebug ``` Internal, external CI. Reviewed By: mweststrate Differential Revision: D19948797 Pulled By: passy fbshipit-source-id: b2e98d3a5c89b0fc77c157683cde90997232fee0
This commit is contained in:
committed by
Facebook Github Bot
parent
a0cd6e3adb
commit
47471d2def
@@ -95,7 +95,6 @@ list(APPEND SRC_FILES ${FOLLY_DIR}/io/async/HHWheelTimer.cpp
|
||||
${FOLLY_DIR}/SocketAddress.cpp
|
||||
${FOLLY_DIR}/Executor.cpp
|
||||
${FOLLY_DIR}/FileUtil.cpp
|
||||
${FOLLY_DIR}/lang/ColdClass.cpp
|
||||
${FOLLY_DIR}/lang/Assume.cpp
|
||||
${FOLLY_DIR}/json.cpp
|
||||
${FOLLY_DIR}/Unicode.cpp
|
||||
|
||||
Reference in New Issue
Block a user