Fix Flipper lints #16

Summary: Larger list of fixes. Adding another package to the flipper export is a bit nasty but it unblocks us for now and centralises `remote` access which seems like a win for FAAS.

Reviewed By: mweststrate

Differential Revision: D30785421

fbshipit-source-id: 931297e8566b5d8a213b69ae87d0cda7648b3ed4

desktop/plugins/public/layout/Inspector.tsx

@@ -119,13 +119,16 @@ export default class Inspector extends Component<Props, State> {
     if (!this.props.client.isConnected) {
       return;
     }
-    this.props.client.call(this.call().GET_ROOT).then((root: Element) => {
-      this.props.setPersistedState({
-        [this.props.ax ? 'rootAXElement' : 'rootElement']: root.id,
-      });
-      this.updateElement(root.id, {...root, expanded: true});
-      this.performInitialExpand(root);
-    });
+    this.props.client
+      .call(this.call().GET_ROOT)
+      .then((root: Element) => {
+        this.props.setPersistedState({
+          [this.props.ax ? 'rootAXElement' : 'rootElement']: root.id,
+        });
+        this.updateElement(root.id, {...root, expanded: true});
+        this.performInitialExpand(root);
+      })
+      .catch((e) => console.error('[layout] GET_ROOT failed:', e));
 
     this.props.client.subscribe(
       this.call().INVALIDATE,
@@ -419,13 +422,15 @@ export default class Inspector extends Component<Props, State> {
     if (shouldExpand) {
       this.updateElement(id, {expanded: shouldExpand});
     }
-    this.getChildren(id, {}).then((children) => {
-      if (deep) {
-        children.forEach((child) =>
-          this.onElementExpanded(child.id, deep, shouldExpand),
-        );
-      }
-    });
+    this.getChildren(id, {})
+      .then((children) => {
+        if (deep) {
+          children.forEach((child) =>
+            this.onElementExpanded(child.id, deep, shouldExpand),
+          );
+        }
+      })
+      .catch((e) => console.error('[layout] getChildren failed:', e));
     if (!shouldExpand) {
       this.updateElement(id, {expanded: shouldExpand});
     }

desktop/plugins/public/layout/Search.tsx

@@ -101,7 +101,8 @@ export default class Search extends Component<Props, State> {
         .call('getSearchResults', {query, axEnabled: this.props.inAXMode})
         .then((response) =>
           this.displaySearchResults(response, this.props.inAXMode),
-        );
+        )
+        .catch((e) => console.log('[layout] getSearchResults failed:', e));
     }
   }
 

desktop/plugins/public/layout/index.tsx

@@ -218,9 +218,12 @@ export default class LayoutPlugin extends FlipperPlugin<
     if (this.client.isConnected) {
       // persist searchActive state when moving between plugins to prevent multiple
       // TouchOverlayViews since we can't edit the view heirarchy in onDisconnect
-      this.client.call('isSearchActive').then(({isSearchActive}) => {
-        this.setState({inTargetMode: isSearchActive});
-      });
+      this.client
+        .call('isSearchActive')
+        .then(({isSearchActive}) => {
+          this.setState({inTargetMode: isSearchActive});
+        })
+        .catch((e) => console.error('[layout] isSearchActive call failed:', e));
 
       // disable target mode after
       this.client.subscribe('select', () => {