Fix Flipper lints #16

Summary: Larger list of fixes. Adding another package to the flipper export is a bit nasty but it unblocks us for now and centralises `remote` access which seems like a win for FAAS.

Reviewed By: mweststrate

Differential Revision: D30785421

fbshipit-source-id: 931297e8566b5d8a213b69ae87d0cda7648b3ed4

desktop/plugins/public/crash_reporter/index.tsx

@@ -30,7 +30,7 @@ export type CrashLog = {
 
 export function devicePlugin(client: DevicePluginClient) {
   let notificationID = -1;
-  let watcher: FSWatcher | undefined;
+  let watcher: Promise<FSWatcher | undefined>;
 
   const crashes = createState<Crash[]>([], {persist: 'crashes'});
   const selectedCrash = createState<string | undefined>();
@@ -70,7 +70,14 @@ export function devicePlugin(client: DevicePluginClient) {
   }
 
   client.onDestroy(() => {
-    watcher?.close();
+    watcher
+      .then((watcher) => watcher?.close())
+      .catch((e) =>
+        console.error(
+          '[crash_reporter] FSWatcher failed resoving on destroy:',
+          e,
+        ),
+      );
   });
 
   return {

desktop/plugins/public/crash_reporter/ios-crash-utils.tsx

@@ -8,10 +8,9 @@
  */
 
 import type {CrashLog} from './index';
-import fs from 'fs';
+import fs from 'fs-extra';
 import os from 'os';
 import path from 'path';
-import {promisify} from 'util';
 import {UNKNOWN_CRASH_REASON} from './crash-utils';
 
 export function parseIosCrash(content: string) {
@@ -64,35 +63,34 @@ export function parsePath(content: string): string | null {
   return path.trim();
 }
 
-export function addFileWatcherForiOSCrashLogs(
+export async function addFileWatcherForiOSCrashLogs(
   serial: string,
   reportCrash: (payload: CrashLog) => void,
 ) {
   const dir = path.join(os.homedir(), 'Library', 'Logs', 'DiagnosticReports');
-  if (!fs.existsSync(dir)) {
+  if (!(await fs.pathExists(dir))) {
     // Directory doesn't exist
     return;
   }
-  return fs.watch(dir, (_eventType, filename) => {
+  return fs.watch(dir, async (_eventType, filename) => {
     // We just parse the crash logs with extension `.crash`
     const checkFileExtension = /.crash$/.exec(filename);
     if (!filename || !checkFileExtension) {
       return;
     }
     const filepath = path.join(dir, filename);
-    promisify(fs.exists)(filepath).then((exists) => {
-      if (!exists) {
+    const exists = await fs.pathExists(filepath);
+    if (!exists) {
+      return;
+    }
+    fs.readFile(filepath, 'utf8', function (err, data) {
+      if (err) {
+        console.warn('Failed to read crash file', err);
         return;
       }
-      fs.readFile(filepath, 'utf8', function (err, data) {
-        if (err) {
-          console.warn('Failed to read crash file', err);
-          return;
-        }
-        if (shouldShowiOSCrashNotification(serial, data)) {
-          reportCrash(parseIosCrash(data));
-        }
-      });
+      if (shouldShowiOSCrashNotification(serial, data)) {
+        reportCrash(parseIosCrash(data));
+      }
     });
   });
 }

desktop/plugins/public/crash_reporter/package.json

@@ -32,6 +32,8 @@
     "url": "https://fb.workplace.com/groups/220760072184928/"
   },
   "dependencies": {
+    "@types/fs-extra": "^9.0.12",
+    "fs-extra": "^10.0.0",
     "unicode-substring": "^1.0.0"
   },
   "peerDependencies": {