Fix Flipper lints #16

Summary: Larger list of fixes. Adding another package to the flipper export is a bit nasty but it unblocks us for now and centralises `remote` access which seems like a win for FAAS.

Reviewed By: mweststrate

Differential Revision: D30785421

fbshipit-source-id: 931297e8566b5d8a213b69ae87d0cda7648b3ed4

desktop/plugins/postinstall.ts

@@ -7,7 +7,9 @@
  * @format
  */
 
-import {execSync} from 'child_process';
+/* eslint-disable flipper/no-console-error-without-context */
+
+import {exec} from 'promisify-child-process';
 import path from 'path';
 import fs from 'fs-extra';
 import pmap from 'p-map';
@@ -90,14 +92,12 @@ async function postinstall(): Promise<number> {
     }
     return 1;
   }
-  execSync('yarn install --mutex network:30330', {
+  await exec('yarn install --mutex network:30330', {
     cwd: publicPluginsDir,
-    stdio: 'inherit',
   });
   if (await fs.pathExists(fbPluginsDir)) {
-    execSync('yarn install --mutex network:30330', {
+    await exec('yarn install --mutex network:30330', {
       cwd: fbPluginsDir,
-      stdio: 'inherit',
     });
   }
   const peerDependenciesArray = Object.keys(peerDependencies);