Select both required and default plugins

Summary: This diff selects both required and default plugins in the plugin selection menu

Reviewed By: mweststrate

Differential Revision: D19905737

fbshipit-source-id: 86fb308f8f189350cc035d14174b34fac14a2cd1
This commit is contained in:
Pritesh Nandgaonkar
2020-02-15 08:11:50 -08:00
committed by Facebook Github Bot
parent 35ed3ce1a4
commit 467b54a6fb

View File

@@ -65,6 +65,12 @@ export class Group {
workplaceGroupID: number; workplaceGroupID: number;
supportedOS: Array<OS>; supportedOS: Array<OS>;
getPluginsToSelect(): Array<string> {
return Array.from(
new Set([...this.defaultPlugins, ...this.requiredPlugins]),
);
}
getValidationMessage( getValidationMessage(
selectedPlugins: Array<string>, selectedPlugins: Array<string>,
selectedOS: OS | null, selectedOS: OS | null,
@@ -192,7 +198,7 @@ export class Group {
store.dispatch( store.dispatch(
setSelectedPlugins( setSelectedPlugins(
this.defaultPlugins.filter(s => { this.getPluginsToSelect().filter(s => {
return pluginsList.map(s => s.id).includes(s); return pluginsList.map(s => s.id).includes(s);
}), }),
), ),
@@ -253,7 +259,7 @@ export const LITHO_GROUP = new Group(
'Litho Support', 'Litho Support',
LITHO_SUPPORT_GROUP_ID, LITHO_SUPPORT_GROUP_ID,
['Inspector'], ['Inspector'],
['Inspector', 'Sections', 'DeviceLogs'], ['Sections', 'DeviceLogs'],
['Android'], ['Android'],
); );
@@ -261,7 +267,7 @@ export const GRAPHQL_ANDROID_GROUP = new Group(
'GraphQL Android Support', 'GraphQL Android Support',
GRAPHQL_ANDROID_SUPPORT_GROUP_ID, GRAPHQL_ANDROID_SUPPORT_GROUP_ID,
['GraphQL'], ['GraphQL'],
['GraphQL', 'DeviceLogs'], ['DeviceLogs'],
['Android'], ['Android'],
); );
@@ -269,7 +275,7 @@ export const GRAPHQL_IOS_GROUP = new Group(
'GraphQL iOS Support', 'GraphQL iOS Support',
GRAPHQL_IOS_SUPPORT_GROUP_ID, GRAPHQL_IOS_SUPPORT_GROUP_ID,
['GraphQL'], ['GraphQL'],
['GraphQL', 'DeviceLogs'], ['DeviceLogs'],
['iOS'], ['iOS'],
); );