Revert D44566060: Multisect successfully blamed D44566060 for test or build failures

Summary:
This diff is reverting D44566060
D44566060: Add Flipper support for secondary processes in Messenger VR by rra has been identified to be causing the following test or build failures:

Tests affected:
- [//fbandroid/javatests/com/facebook/messenger:no_sonar_in_production - main](https://www.internalfb.com/intern/test/281474996792449/)

Here's the Multisect link:
https://www.internalfb.com/multisect/1809753
Here are the tasks that are relevant to this breakage:

We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.

If you believe this diff has been generated in error you may Commandeer and Abandon it.

Reviewed By: passy

Differential Revision: D44682510

fbshipit-source-id: c0ae489bc5ae22c5339edd2c8988126b0adedd7f
This commit is contained in:
generatedunixname89002005232357
2023-04-05 10:15:57 -07:00
committed by Facebook GitHub Bot
parent 794c29f320
commit 452154802f

View File

@@ -26,8 +26,7 @@ public final class AndroidFlipperClient {
private static final String[] REQUIRED_PERMISSIONS = private static final String[] REQUIRED_PERMISSIONS =
new String[] {"android.permission.INTERNET", "android.permission.ACCESS_WIFI_STATE"}; new String[] {"android.permission.INTERNET", "android.permission.ACCESS_WIFI_STATE"};
public static synchronized FlipperClient getInstance( public static synchronized FlipperClient getInstance(Context context) {
Context context, String id, String deviceName, String processName, String packageName) {
if (!sIsInitialized) { if (!sIsInitialized) {
if (!(BuildConfig.IS_INTERNAL_BUILD || BuildConfig.LOAD_FLIPPER_EXPLICIT)) { if (!(BuildConfig.IS_INTERNAL_BUILD || BuildConfig.LOAD_FLIPPER_EXPLICIT)) {
Log.e("Flipper", "Attempted to initialize in non-internal build"); Log.e("Flipper", "Attempted to initialize in non-internal build");
@@ -59,23 +58,16 @@ public final class AndroidFlipperClient {
FlipperProps.getAltSecurePort(), FlipperProps.getAltSecurePort(),
getServerHost(app), getServerHost(app),
"Android", "Android",
deviceName, getFriendlyDeviceName(),
id, getId(),
processName, getRunningAppName(app),
packageName, getPackageName(app),
privateAppDirectory); privateAppDirectory);
sIsInitialized = true; sIsInitialized = true;
} }
return FlipperClientImpl.getInstance(); return FlipperClientImpl.getInstance();
} }
public static synchronized FlipperClient getInstance(Context context) {
final Context app =
context.getApplicationContext() == null ? context : context.getApplicationContext();
return getInstance(
context, getId(), getFriendlyDeviceName(), getRunningAppName(app), getPackageName(app));
}
@Nullable @Nullable
public static synchronized FlipperClient getInstanceIfInitialized() { public static synchronized FlipperClient getInstanceIfInitialized() {
if (!sIsInitialized) { if (!sIsInitialized) {