From 45157c36753714a6b03b69f648927a29cdd67560 Mon Sep 17 00:00:00 2001
From: Anton Kastritskiy <antonk52@meta.com>
Date: Fri, 10 Nov 2023 09:54:08 -0800
Subject: [PATCH] Change order of ios checks

Summary:
Current order is confusion, the new order better reflects order at which users gets started with iOS

1. Install Xcode
2. Point Xcode-select at most recent xcode version
3. Install SDK
4. Accept Xcode SDK license
5. check idb health

Reviewed By: lblasa

Differential Revision: D51202202

fbshipit-source-id: da39acf7ef325889c2288b3941cef0ca803356cd
---
 desktop/doctor/src/index.tsx | 40 ++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/desktop/doctor/src/index.tsx b/desktop/doctor/src/index.tsx
index 22fb87da6..41953c166 100644
--- a/desktop/doctor/src/index.tsx
+++ b/desktop/doctor/src/index.tsx
@@ -137,26 +137,6 @@ export function getHealthchecks(): FlipperDoctor.Healthchecks {
             isRequired: false,
             isSkipped: false,
             healthchecks: [
-              {
-                key: 'ios.sdk',
-                label: 'SDK Installed',
-                isRequired: true,
-                run: async (e: FlipperDoctor.EnvironmentInfo) => {
-                  const hasProblem =
-                    !e.SDKs['iOS SDK'] ||
-                    !e.SDKs['iOS SDK'].Platforms ||
-                    !e.SDKs['iOS SDK'].Platforms.length;
-                  const message = hasProblem
-                    ? 'iOS SDK is not installed. You can install it using Xcode (https://developer.apple.com/xcode/).'
-                    : `iOS SDK is installed for the following platforms: ${JSON.stringify(
-                        e.SDKs['iOS SDK'].Platforms,
-                      )}.`;
-                  return {
-                    hasProblem,
-                    message,
-                  };
-                },
-              },
               {
                 key: 'ios.xcode',
                 label: 'XCode Installed',
@@ -217,6 +197,26 @@ export function getHealthchecks(): FlipperDoctor.Healthchecks {
                   };
                 },
               },
+              {
+                key: 'ios.sdk',
+                label: 'SDK Installed',
+                isRequired: true,
+                run: async (e: FlipperDoctor.EnvironmentInfo) => {
+                  const hasProblem =
+                    !e.SDKs['iOS SDK'] ||
+                    !e.SDKs['iOS SDK'].Platforms ||
+                    !e.SDKs['iOS SDK'].Platforms.length;
+                  const message = hasProblem
+                    ? 'iOS SDK is not installed. You can install it using Xcode (https://developer.apple.com/xcode/).'
+                    : `iOS SDK is installed for the following platforms: ${JSON.stringify(
+                        e.SDKs['iOS SDK'].Platforms,
+                      )}.`;
+                  return {
+                    hasProblem,
+                    message,
+                  };
+                },
+              },
               {
                 key: 'ios.xctrace',
                 label: 'xctrace exists',