Separate the concepts of archived and disconnected devices

Summary:
Minor code cleanup to avoid future confusion:

- archived: a device that was imported from a Flipper trace, and only has persisted state
- (dis)connected: a real stateful device that might or might not have an active connection

Reviewed By: nikoant

Differential Revision: D26275459

fbshipit-source-id: eba554b37c39711e367c3795ff4456329a303c22

desktop/app/src/chrome/MetroButton.tsx

@@ -12,13 +12,12 @@ import MetroDevice, {MetroReportableEvent} from '../devices/MetroDevice';
 import {useStore} from '../utils/useStore';
 import {Button as AntButton} from 'antd';
 import {MenuOutlined, ReloadOutlined} from '@ant-design/icons';
-
-type LogEntry = {};
+import {theme} from 'flipper-plugin';
 
 export default function MetroButton() {
   const device = useStore((state) =>
     state.connections.devices.find(
-      (device) => device.os === 'Metro' && !device.isArchived,
+      (device) => device.os === 'Metro' && device.connected.get(),
     ),
   ) as MetroDevice | undefined;
 
@@ -69,6 +68,7 @@ export default function MetroButton() {
           sendCommand('reload');
         }}
         loading={progress < 1}
+        style={{color: _hasBuildError ? theme.errorColor : undefined}}
       />
       <AntButton
         icon={<MenuOutlined />}