jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove uneeded operators from simplified config

Browse Source 
Summary:
The single value == / contains are covered by the setlike oper /ators.

Less operators is better as less overwhelming. Plus with the group operators you can add futher options or'ed togther which is a complain from the user.

Reviewed By: aigoncharov

Differential Revision: D51255253

fbshipit-source-id: 72f909319fd3d8034ebe4725a5a5254ecfeb074b
This commit is contained in:
Luke De Feo
2023-11-13 06:02:32 -08:00
committed by Facebook GitHub Bot
parent 4ada8b9322
commit 437e67cd7f
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearch.tsx
View File

@@ -444,8 +444,6 @@ export function DataTable<T extends object>(
} }
case 'string': { case 'string': {
columnPowerSearchOperators = [ columnPowerSearchOperators = [
dataTablePowerSearchOperators.string_contains(),
dataTablePowerSearchOperators.string_not_contains(),
dataTablePowerSearchOperators.string_matches_exactly(), dataTablePowerSearchOperators.string_matches_exactly(),
dataTablePowerSearchOperators.string_not_matches_exactly(), dataTablePowerSearchOperators.string_not_matches_exactly(),
dataTablePowerSearchOperators.string_set_contains_any_of(), dataTablePowerSearchOperators.string_set_contains_any_of(),
@@ -484,9 +482,6 @@ export function DataTable<T extends object>(
} }
columnPowerSearchOperators = [ columnPowerSearchOperators = [
dataTablePowerSearchOperators.enum_is(enumLabels),
dataTablePowerSearchOperators.enum_is_not(enumLabels),
dataTablePowerSearchOperators.enum_is_nullish_or(enumLabels),
dataTablePowerSearchOperators.enum_set_is_any_of(enumLabels), dataTablePowerSearchOperators.enum_set_is_any_of(enumLabels),
dataTablePowerSearchOperators.enum_set_is_none_of(enumLabels), dataTablePowerSearchOperators.enum_set_is_none_of(enumLabels),
dataTablePowerSearchOperators.enum_set_is_nullish_or_any_of( dataTablePowerSearchOperators.enum_set_is_nullish_or_any_of(